Initial commit of all previous Chrome build scripts.

Initial commit of all previous Chrome build scripts.

No changes in this commit except for one to .gitignore to prevent it
from ignoring the config.* files.

Please review only for layout of the Chrome specific bits.

BUG=111520
TEST=none

[DaleCurtis, 2012-01-26 20:43:56]

PTAL, no

[DaleCurtis, 2012-01-26 20:44:20]

err, no full review necessary, just looking for an okay on the layout.

[Ami GONE FROM CHROMIUM, 2012-01-26 20:52:41]

https://chromiumcodereview.appspot.com/9290059/diff/1/README.chromium
File README.chromium (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/README.chromium#newcode123
README.chromium:123:
src/third_party/ffmpeg/source/config/[branding]/[platform]/[variant]
This path is wrong.  I imagine there are a lot of paths that are wrong now. 
Make a pass?

https://chromiumcodereview.appspot.com/9290059/diff/1/chromium/deprecated/REA...
File chromium/deprecated/README.chromium (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/chromium/deprecated/REA...
chromium/deprecated/README.chromium:1: Name: ffmpeg
I'm not crazy for the deprecated/ subdir.
Why not leave as chromium/patches/ and work it down to nothing as patches get
upstreamed?

[DaleCurtis, 2012-01-26 20:55:57]

https://chromiumcodereview.appspot.com/9290059/diff/1/README.chromium
File README.chromium (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/README.chromium#newcode123
README.chromium:123:
src/third_party/ffmpeg/source/config/[branding]/[platform]/[variant]
On 2012/01/26 20:52:41, Ami Fischman wrote:
> This path is wrong.  I imagine there are a lot of paths that are wrong now. 
> Make a pass?

Yeah lots is wrong, I'm committing as is though, so when I do make the fixes
it's easier to review what has changed versus having to inspect every line.

https://chromiumcodereview.appspot.com/9290059/diff/1/chromium/deprecated/REA...
File chromium/deprecated/README.chromium (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/chromium/deprecated/REA...
chromium/deprecated/README.chromium:1: Name: ffmpeg
On 2012/01/26 20:52:41, Ami Fischman wrote:
> I'm not crazy for the deprecated/ subdir.
> Why not leave as chromium/patches/ and work it down to nothing as patches get
> upstreamed?

The idea here was to make it obvious that this is a deprecated workflow. We'll
still continue to upstream them and work down this directory.

[scherkus (not reviewing), 2012-01-27 21:27:07]

re: deprecated folder

I'm assuming it'll take us a long time to get rid of all the patches so won't we
end up living with the deprecated folder for quite some time?

aside from that LGTM from me

https://chromiumcodereview.appspot.com/9290059/diff/1/README.chromium
File README.chromium (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/README.chromium#newcode14
README.chromium:14: 1) If on Windows, refer to our MinGW/MSYS environment setup:
yeah this will all need updating I guess

https://chromiumcodereview.appspot.com/9290059/diff/1/codereview.settings
File codereview.settings (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/codereview.settings#new...
codereview.settings:10: LINT_IGNORE_REGEX: webkit/api/.*
sanity check: are all these settings correct?

[DaleCurtis, 2012-01-27 23:27:10]

+nyslvain for codereview.settings sanity check.

I took another look through the patch readme and it's a bit depressing, so
you're right about this folder being around for a bit. I've gone ahead and
removed the deprecated prefix and shuffled the files into chromium/patches and
chromium/scripts as appropriate.

https://chromiumcodereview.appspot.com/9290059/diff/1/codereview.settings
File codereview.settings (right):

https://chromiumcodereview.appspot.com/9290059/diff/1/codereview.settings#new...
codereview.settings:10: LINT_IGNORE_REGEX: webkit/api/.*
On 2012/01/27 21:27:07, scherkus wrote:
> sanity check: are all these settings correct?

I just copied it from src root, so possibly not. I did use them to upload this
CL though.

[Ami GONE FROM CHROMIUM, 2012-01-27 23:32:44]

deprecated-free layout LGTM

[nsylvain, 2012-01-30 22:23:39]

I've never actually looked at a codereview.settings for a git repo, so i'm not
100% sure. You guys don't want to use gerrit for code reviews?  LGTM either way,
this should not impact much even if it's wrong.

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings
File codereview.settings (right):

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
codereview.settings:4: VIEW_VC:
http://src.chromium.org/viewvc/chrome?view=rev&revision=
This probably won't work, but it might be OK.

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
codereview.settings:7: TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try
You might want to remove this, you won't be able to try those patches anyway.

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
codereview.settings:10: LINT_IGNORE_REGEX: webkit/api/.*
Is this needed?

[DaleCurtis, 2012-01-30 22:40:54]

I wasn't aware we could use gerrit for Chrome code reviews? How does that work?

On 2012/01/30 22:23:39, nsylvain wrote:
> I've never actually looked at a codereview.settings for a git repo, so i'm not
> 100% sure. You guys don't want to use gerrit for code reviews?  LGTM either
way,
> this should not impact much even if it's wrong.
> 
> https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings
> File codereview.settings (right):
> 
>
https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
> codereview.settings:4: VIEW_VC:
> http://src.chromium.org/viewvc/chrome?view=rev&revision=
> This probably won't work, but it might be OK.
> 
>
https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
> codereview.settings:7: TRYSERVER_SVN_URL:
svn://svn.chromium.org/chrome-try/try
> You might want to remove this, you won't be able to try those patches anyway.
> 
>
https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
> codereview.settings:10: LINT_IGNORE_REGEX: webkit/api/.*
> Is this needed?

[nsylvain, 2012-01-30 23:34:42]

On Mon, Jan 30, 2012 at 2:40 PM, <dalecurtis@chromium.org> wrote:

> I wasn't aware we could use gerrit for Chrome code reviews? How does that
> work?


git push
ssh://gerrit.chromium.org:29418/chromium/third_party/ffmpegHEAD:refs/for/master
And then open http://gerrit.chromium.org , you should see your change in
your pending reviews.

Nicolas


>
>
> On 2012/01/30 22:23:39, nsylvain wrote:
>
>> I've never actually looked at a codereview.settings for a git repo, so
>> i'm not
>> 100% sure. You guys don't want to use gerrit for code reviews?  LGTM
>> either
>>
> way,
>
>> this should not impact much even if it's wrong.
>>
>
>  https://chromiumcodereview.**appspot.com/9290059/diff/**
>>
10001/codereview.settings<https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings>
>> File codereview.settings (right):
>>
>
>
> https://chromiumcodereview.**appspot.com/9290059/diff/**
>
10001/codereview.settings#**newcode4<https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings#newcode4>
>
>> codereview.settings:4: VIEW_VC:
>>
http://src.chromium.org/**viewvc/chrome?view=rev&**revision=<http://src.chrom...
>> This probably won't work, but it might be OK.
>>
>
>
> https://chromiumcodereview.**appspot.com/9290059/diff/**
>
10001/codereview.settings#**newcode7<https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings#newcode7>
>
>> codereview.settings:7: TRYSERVER_SVN_URL:
>>
>
svn://svn.chromium.org/chrome-**try/try<http://svn.chromium.org/chrome-try/try>
>
>> You might want to remove this, you won't be able to try those patches
>> anyway.
>>
>
>
> https://chromiumcodereview.**appspot.com/9290059/diff/**
>
10001/codereview.settings#**newcode10<https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings#newcode10>
>
>> codereview.settings:10: LINT_IGNORE_REGEX: webkit/api/.*
>> Is this needed?
>>
>
>
>
>
https://chromiumcodereview.**appspot.com/9290059/<https://chromiumcodereview....
>

[DaleCurtis, 2012-01-31 01:18:03]

Thanks Nicolas. I think the team is more comfortable with Rietveld right now. 
I'll push all my initial bits through Gerrit though just to try it out:

https://gerrit.chromium.org/gerrit/#change,15065

Pushing. Thanks for review!

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings
File codereview.settings (right):

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
codereview.settings:4: VIEW_VC:
http://src.chromium.org/viewvc/chrome?view=rev&revision=
On 2012/01/30 22:23:39, nsylvain wrote:
> This probably won't work, but it might be OK.

Removed.

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
codereview.settings:7: TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try
On 2012/01/30 22:23:39, nsylvain wrote:
> You might want to remove this, you won't be able to try those patches anyway.

Done.

https://chromiumcodereview.appspot.com/9290059/diff/10001/codereview.settings...
codereview.settings:10: LINT_IGNORE_REGEX: webkit/api/.*
On 2012/01/30 22:23:39, nsylvain wrote:
> Is this needed?

Removed.