Add type refinement to code completion as an experimental option.

Add type refinement to code completion as an experimental option.
Fixes 855, 502.

To enable, add this to your .options file:
com.google.dart.tools.core/debug/RefineTypes = true

Type refinement provides useful type info for q and x in the following code:

void main() {
  var x = new List(), y = x.length();
  var q = [0], z = q.length;
  x.isEmpty();
  q.isEmpty();
  if (x is List) {
    x.add(3);
  }
}
Committed: https://code.google.com/p/dart/source/detail?r=3610

[danrubel, 2012-01-25 20:12:30]

Nice! LGTM...

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
(right):

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java:876:
public static final boolean DEBUG_REFINE =
"true".equalsIgnoreCase(Platform.getDebugOption("com.google.dart.tools.ui/debug/RefineTypes"));
Please move these into DartCoreDebug

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/TypeRefiner.java
(right):

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/TypeRefiner.java:176:
if (arg1.getSymbol() == ident.getSymbol()) {
Should this be .equals(...) ?  Or do you want identity?
Perhaps a comment to explain the choice?

[messick, 2012-01-25 21:58:48]

PTAL

Note that the name of the option has changed.

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
(right):

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java:876:
public static final boolean DEBUG_REFINE =
"true".equalsIgnoreCase(Platform.getDebugOption("com.google.dart.tools.ui/debug/RefineTypes"));
On 2012/01/25 20:12:30, danrubel wrote:
> Please move these into DartCoreDebug

Done.

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/TypeRefiner.java
(right):

http://codereview.chromium.org/9290015/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/TypeRefiner.java:176:
if (arg1.getSymbol() == ident.getSymbol()) {
On 2012/01/25 20:12:30, danrubel wrote:
> Should this be .equals(...) ?  Or do you want identity?
> Perhaps a comment to explain the choice?
Elements are unique. However, that could change (I suppose) so I added a helper
function to call equals().

[messick, 2012-01-25 22:27:45]

PTAL

Note that the name of the option has changed.

[danrubel, 2012-01-25 23:08:33]

lgtm