Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 9289047: Reduce boot-up memory use of V8. (Closed)

Created:
8 years, 11 months ago by Erik Corry
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reduce boot-up memory use of V8. This is a recommit of http://codereview.chromium.org/9179012 after fixing what turned out to be unrelated out-of-memory errors. That was a rebase of http://codereview.chromium.org/9017009/ Committed: https://code.google.com/p/v8/source/detail?r=10542

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -210 lines) Patch
M src/deoptimizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 3 chunks +17 lines, -9 lines 1 comment Download
M src/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 7 chunks +15 lines, -11 lines 0 comments Download
M src/serialize.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/snapshot.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/spaces.h View 20 chunks +51 lines, -41 lines 1 comment Download
M src/spaces.cc View 31 chunks +261 lines, -88 lines 0 comments Download
M src/spaces-inl.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/store-buffer.cc View 2 chunks +40 lines, -36 lines 0 comments Download
M src/utils.h View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-spaces.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 11 months ago (2012-01-26 14:05:40 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-26 16:12:00 UTC) #2
LGTM with comments addressed.

https://chromiumcodereview.appspot.com/9289047/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/9289047/diff/1/src/heap.cc#newcode588
src/heap.cc:588: while (gc_performed) {
it seems to me that this loop can go on forever. can you prove that we are not
going to loop here forever doing GC if OS refuses us new pages and we at the
boundary of soft/hard limit?

https://chromiumcodereview.appspot.com/9289047/diff/1/src/spaces.h
File src/spaces.h (right):

https://chromiumcodereview.appspot.com/9289047/diff/1/src/spaces.h#newcode1598
src/spaces.h:1598: void IncreaseUnsweptFreeBytes(Page* p) {
I wonder if this needs to be adjusted somehow to accomodate pages that are
smaller than kObjectAreaSize.

(this is used to provide estimate of SizeOfObjects when lazy sweeping is active.
can lazyly swept pages be partially uncommitted?)

Powered by Google App Engine
This is Rietveld 408576698