Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: frog/value.dart

Issue 9284030: cleanup from r3556 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge again Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/type.dart ('k') | utils/tests/dartdoc/dartdoc.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/value.dart
diff --git a/frog/value.dart b/frog/value.dart
index 90c6903dbfc45fcd65001269ae116787aa52e7c5..00fd7fc0abae34b2b4a01bb3c6d723109be42e9c 100644
--- a/frog/value.dart
+++ b/frog/value.dart
@@ -75,8 +75,9 @@ class PureStaticValue extends Value {
Value setIndex(CallingContext context, Value index, Node node, Value value,
[int kind=0, int returnKind=ReturnKind.IGNORE]) {
- return invoke(context, ':setindex', node,
+ var tmp = invoke(context, ':setindex', node,
new Arguments(null, [index, value]));
+ return new PureStaticValue(value.type, node.span);
}
Value unop(int kind, CallingContext context, var node) {
@@ -809,7 +810,8 @@ function \$assert_${toType.name}(x) {
void convertWarning(Type toType) {
// TODO(jmesserly): better error messages for type conversion failures
- world.warning('type "${type.name}" is not assignable to "${toType.name}"',
+ world.warning(
+ 'type "${type.fullname}" is not assignable to "${toType.fullname}"',
span);
}
« no previous file with comments | « frog/type.dart ('k') | utils/tests/dartdoc/dartdoc.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698