Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: frog/type.dart

Issue 9284030: cleanup from r3556 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge again Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/tests/frog/frog.status ('k') | frog/value.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/type.dart
diff --git a/frog/type.dart b/frog/type.dart
index 64db0e8d7badb987aca74efd2de2a7020211b565..d21756ac0098c087ee859dc1108d1ec885776dfe 100644
--- a/frog/type.dart
+++ b/frog/type.dart
@@ -89,6 +89,9 @@ class Type extends Element {
String get typeofName() => null;
+ String get fullname() =>
+ library.name !== null ? '${library.name}.$name' : name;
+
Map<String, Member> get members() => null;
Definition get definition() => null;
FactoryMap get factories() => null;
@@ -1153,15 +1156,13 @@ class DefinedType extends Type {
var jsname = '${jsname}_${Strings.join(jsnames, '\$')}';
var simpleName = '${name}<${Strings.join(names, ', ')}>';
- // TODO(jimhug): Should use jsnames or better type keys.
- var key = Strings.join(names, '\$');
- var ret = _concreteTypes[key];
+ var ret = _concreteTypes[jsname];
if (ret == null) {
ret = new DefinedType(simpleName, library, definition, isClass);
ret.baseGenericType = this;
ret.typeArgsInOrder = typeArgs;
ret._jsname = jsname;
- _concreteTypes[key] = ret;
+ _concreteTypes[jsname] = ret;
ret.resolve();
}
return ret;
« no previous file with comments | « frog/tests/frog/frog.status ('k') | frog/value.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698