Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 9271054: Send replies to sync IPCs from swapped out renderers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test on Mac/Win Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index 013f8d56eca31777e282c120ae83f4b9465560df..2990710fcac09090d9fe2499d4c861242fc055f0 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -2067,6 +2067,8 @@ void TabContents::RunBeforeUnloadConfirm(const RenderViewHost* rvh,
!delegate_ ||
delegate_->ShouldSuppressDialogs();
if (suppress_this_message) {
+ // TODO(creis): We need to send this reply to the RVH that sent the request,
+ // even if it's not the current RVH. http;//crbug.com/109792.
GetRenderViewHost()->JavaScriptDialogClosed(reply_msg, true, string16());
Matt Perry 2012/01/27 19:38:13 Isn't |rvh| the RVH that sent the request?
Charlie Reis 2012/01/27 20:11:30 Done.
return;
}
@@ -2264,6 +2266,8 @@ void TabContents::OnDialogClosed(IPC::Message* reply_msg,
tab_close_start_time_ = base::TimeTicks();
}
is_showing_before_unload_dialog_ = false;
+ // TODO(creis): We need to send this reply to the RVH that sent the request,
+ // even if it's not the current RVH. http;//crbug.com/109792.
GetRenderViewHost()->JavaScriptDialogClosed(reply_msg, success, user_input);
}
« no previous file with comments | « content/browser/tab_contents/render_view_host_manager_unittest.cc ('k') | content/common/swapped_out_messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698