Send replies to sync IPCs from swapped out renderers.

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 2049 matching lines @@
                                          const string16& message,
                                          IPC::Message* reply_msg) {
   if (delegate_)
     delegate_->WillRunBeforeUnloadConfirm();
 
   bool suppress_this_message =
       rvh->is_swapped_out() ||
       !delegate_ ||
       delegate_->ShouldSuppressDialogs();
   if (suppress_this_message) {
+    // TODO(creis): We need to send this reply to the RVH that sent the request,
+    // even if it's not the current RVH.  http;//crbug.com/109792.
     GetRenderViewHost()->JavaScriptDialogClosed(reply_msg, true, string16());

[Matt Perry, 2012/01/27 19:38:13]

Isn't |rvh| the RVH that sent the request?

[Charlie Reis, 2012/01/27 20:11:30]

Done.

     return;
   }
 
   is_showing_before_unload_dialog_ = true;
   dialog_creator_ = delegate_->GetJavaScriptDialogCreator();
   dialog_creator_->RunBeforeUnloadDialog(this,
                                          message,
                                          reply_msg);
 }
 
@@ skipping 176 matching lines @@
                                  bool success,
                                  const string16& user_input) {
   if (is_showing_before_unload_dialog_ && !success) {
     // If a beforeunload dialog is canceled, we need to stop the throbber from
     // spinning, since we forced it to start spinning in Navigate.
     DidStopLoading();
 
     tab_close_start_time_ = base::TimeTicks();
   }
   is_showing_before_unload_dialog_ = false;
+  // TODO(creis): We need to send this reply to the RVH that sent the request,
+  // even if it's not the current RVH.  http;//crbug.com/109792.
   GetRenderViewHost()->JavaScriptDialogClosed(reply_msg, success, user_input);
 }
 
 gfx::NativeWindow TabContents::GetDialogRootWindow() const {
   return view_->GetTopLevelNativeWindow();
 }
 
 void TabContents::OnDialogShown() {
   Activate();
 }
 
 void TabContents::SetEncoding(const std::string& encoding) {
   encoding_ = content::GetContentClient()->browser()->
       GetCanonicalEncodingNameByAliasName(encoding);
 }
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = GetView()->CreateViewForWidget(rvh);
   // Can be NULL during tests.
   if (rwh_view)
     rwh_view->SetSize(GetView()->GetContainerSize());
 }