Issue 9271018: Merge 115621 - Refactor ProfileInfoCacheObserver interface and usage thereof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9271018: Merge 115621 - Refactor ProfileInfoCacheObserver interface and usage thereof. (Closed)

Created:
8 years, 11 months ago by sail

Modified:
8 years, 11 months ago

Reviewers:
SteveT

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/963/src/

Visibility:
Public.

More Reviews

Description

Merge 115621 - Refactor ProfileInfoCacheObserver interface and usage thereof. We want to simplify OnProfileAdded and OnProfileAvatarChanged so decouple the Observer interface a bit away from ProfileShortcutManagerWin. Instead, classes that implement the interface should fetch the global cache object and retrieve any additional information it needs from there when they are notified. BUG=109447 TEST=Ensure that ProfileInfoCacheTest and BackgroundModeManagerTest unit tests all pass. Review URL: http://codereview.chromium.org/9020013 TBR=stevet@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118526

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -151 lines)			Patch
M	chrome/browser/background/background_mode_manager.h	View	1 chunk	+7 lines, -12 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager.cc	View	5 chunks	+21 lines, -12 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager_unittest.cc	View	1 chunk	+8 lines, -13 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache.cc	View	8 chunks	+15 lines, -35 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache_observer.h	View	1 chunk	+7 lines, -17 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache_unittest.h	View	1 chunk	+9 lines, -13 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache_unittest.cc	View	2 chunks	+24 lines, -13 lines	0 comments	Download
M	chrome/browser/profiles/profile_shortcut_manager_win.h	View	1 chunk	+5 lines, -12 lines	0 comments	Download
M	chrome/browser/profiles/profile_shortcut_manager_win.cc	View	9 chunks	+35 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages