Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 9271014: Another ugly hack to work around ppapi header changes. (Closed)

Created:
8 years, 11 months ago by robertm
Modified:
8 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M libraries/nacl-mounts/base/UrlLoaderJob.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/http2/HTTP2FSOpenJob.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/http2/HTTP2OpenJob.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/http2/HTTP2ReadJob.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/pepper/PepperFileIOJob.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
A libraries/nacl-mounts/util/ppapi_version.h View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertm
PTAL
8 years, 11 months ago (2012-01-20 21:52:19 UTC) #1
pdox
Can you move the hack into a separate local header so that you have only ...
8 years, 11 months ago (2012-01-20 22:11:40 UTC) #2
robertm
I change this to something closer to what I hope will be the long term ...
8 years, 11 months ago (2012-01-20 22:40:30 UTC) #3
pdox
lgtm (but I'm putting you on notice for excessive use of the term "ad hoc"!)
8 years, 11 months ago (2012-01-20 22:48:46 UTC) #4
bradn
8 years, 11 months ago (2012-01-21 00:04:24 UTC) #5
LGTM :-)

Powered by Google App Engine
This is Rietveld 408576698