Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 9270025: Remove renderer dependencies from the GPU client classes. (Closed)

Created:
8 years, 11 months ago by piman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Remove renderer dependencies from the GPU client classes. A future CL will move them out of content/renderer so that they can be used by the browser process. All requests to singleton-like things - e.g. establish a channel to the GPU process - go through a GpuChannelHostFactory, implemented by RenderThreadImpl. BUG=99516 TEST=manually tested Chrome with accelerated content. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120701

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : initialize->Initialize #

Patch Set 5 : add overrides #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -146 lines) Patch
M content/renderer/gpu/command_buffer_proxy.cc View 1 2 chunks +9 lines, -22 lines 0 comments Download
M content/renderer/gpu/gpu_channel_host.h View 6 chunks +33 lines, -1 line 0 comments Download
M content/renderer/gpu/gpu_channel_host.cc View 12 chunks +25 lines, -29 lines 0 comments Download
M content/renderer/gpu/gpu_video_decode_accelerator_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 2 3 4 chunks +18 lines, -18 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 12 chunks +29 lines, -58 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 4 chunks +24 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 4 chunks +48 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +15 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
piman
Note: this needs https://bugs.webkit.org/show_bug.cgi?id=76593 to land first. Also, the patch is written on top of ...
8 years, 11 months ago (2012-01-20 23:03:05 UTC) #1
apatrick_chromium
I'm not an owner for content/renderer but the rest you asked me to review, LGTM.
8 years, 11 months ago (2012-01-20 23:18:56 UTC) #2
Ken Russell (switch to Gerrit)
This looks good to me but I defer the review to Al.
8 years, 11 months ago (2012-01-20 23:40:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9270025/18001
8 years, 10 months ago (2012-02-06 22:31:46 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 03:33:30 UTC) #5
Change committed as 120701

Powered by Google App Engine
This is Rietveld 408576698