Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 9270004: Fix handling of function proxies in higher-order array and string methods, (Closed)

Created:
8 years, 11 months ago by rossberg
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix handling of function proxies in higher-order array and string methods, which use yet another way to determine strict vs non-strict function receivers. R=kmillikin@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10459

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M src/runtime.cc View 1 1 chunk +12 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies-function.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
8 years, 11 months ago (2012-01-20 11:50:07 UTC) #1
Kevin Millikin (Chromium)
8 years, 11 months ago (2012-01-20 12:17:09 UTC) #2
LGTM.

https://chromiumcodereview.appspot.com/9270004/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/9270004/diff/1/src/runtime.cc#newcode1883
src/runtime.cc:1883: JSFunction *function = JSFunction::cast(callable);
Misplaced *.

Powered by Google App Engine
This is Rietveld 408576698