Issue 9270004: Fix handling of function proxies in higher-order array and string methods,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9270004: Fix handling of function proxies in higher-order array and string methods, (Closed)

Created:
8 years, 11 months ago by rossberg

Modified:
8 years, 11 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix handling of function proxies in higher-order array and string methods, which use yet another way to determine strict vs non-strict function receivers. R=kmillikin@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10459

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
	M	src/runtime.cc	View	1	1 chunk	+12 lines, -2 lines	0 comments	Download
	M	test/mjsunit/harmony/proxies-function.js	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

8 years, 11 months ago (2012-01-20 12:17:09 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9270004/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/9270004/diff/1/src/runtime.cc#newcode1883
src/runtime.cc:1883: JSFunction *function = JSFunction::cast(callable);
Misplaced *.

Expand Messages | Collapse Messages