Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9255018: Add a per-tab preference to match WebSettings::images_enabled. (Closed)

Created:
8 years, 11 months ago by mnaganov (inactive)
Modified:
8 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Add a per-tab preference to match WebSettings::images_enabled. kWebKitLoadsImagesAutomatically isn't enough. In plain WebKit one must also set a flag in CachedResourceLoader. In Chrome this loader class isn't used, and image loading control is done via ChromeRenderViewObserver. R=bauerb@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mnaganov (inactive)
8 years, 11 months ago (2012-01-18 16:24:38 UTC) #1
Bernhard Bauer
LGTM. Does |loads_images_automatically| actually do anything? If not, I think we should remove it to ...
8 years, 11 months ago (2012-01-18 16:32:34 UTC) #2
mnaganov_google.com
On 2012/01/18 16:32:34, Bernhard Bauer wrote: > LGTM. > > Does |loads_images_automatically| actually do anything? ...
8 years, 11 months ago (2012-01-18 16:33:55 UTC) #3
mnaganov_google.com
On 2012/01/18 16:33:55, mnaganov wrote: > On 2012/01/18 16:32:34, Bernhard Bauer wrote: > > LGTM. ...
8 years, 11 months ago (2012-01-18 16:40:07 UTC) #4
Peter Kasting
8 years, 11 months ago (2012-01-18 17:32:19 UTC) #5
Rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698