Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/ui/prefs/prefs_tab_helper.cc

Issue 9255018: Add a per-tab preference to match WebSettings::images_enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/common/pref_names.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/prefs/prefs_tab_helper.h" 5 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
6 6
7 #include "base/stringprintf.h" 7 #include "base/stringprintf.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 17 matching lines...) Expand all
28 28
29 using content::WebContents; 29 using content::WebContents;
30 30
31 namespace { 31 namespace {
32 32
33 const char* kPerTabPrefsToObserve[] = { 33 const char* kPerTabPrefsToObserve[] = {
34 prefs::kDefaultCharset, 34 prefs::kDefaultCharset,
35 prefs::kWebKitJavascriptEnabled, 35 prefs::kWebKitJavascriptEnabled,
36 prefs::kWebKitJavascriptCanOpenWindowsAutomatically, 36 prefs::kWebKitJavascriptCanOpenWindowsAutomatically,
37 prefs::kWebKitLoadsImagesAutomatically, 37 prefs::kWebKitLoadsImagesAutomatically,
38 prefs::kWebKitImagesEnabled,
38 prefs::kWebKitPluginsEnabled, 39 prefs::kWebKitPluginsEnabled,
39 prefs::kWebKitCursiveFontFamily, 40 prefs::kWebKitCursiveFontFamily,
40 prefs::kWebKitFantasyFontFamily, 41 prefs::kWebKitFantasyFontFamily,
41 prefs::kWebKitFixedFontFamily, 42 prefs::kWebKitFixedFontFamily,
42 prefs::kWebKitSansSerifFontFamily, 43 prefs::kWebKitSansSerifFontFamily,
43 prefs::kWebKitSerifFontFamily, 44 prefs::kWebKitSerifFontFamily,
44 prefs::kWebKitStandardFontFamily, 45 prefs::kWebKitStandardFontFamily,
45 prefs::kWebKitDefaultFontSize, 46 prefs::kWebKitDefaultFontSize,
46 prefs::kWebKitDefaultFixedFontSize, 47 prefs::kWebKitDefaultFixedFontSize,
47 prefs::kWebKitMinimumFontSize, 48 prefs::kWebKitMinimumFontSize,
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 prefs->RegisterBooleanPref(prefs::kWebKitJavascriptEnabled, 95 prefs->RegisterBooleanPref(prefs::kWebKitJavascriptEnabled,
95 pref_defaults.javascript_enabled, 96 pref_defaults.javascript_enabled,
96 PrefService::UNSYNCABLE_PREF); 97 PrefService::UNSYNCABLE_PREF);
97 prefs->RegisterBooleanPref( 98 prefs->RegisterBooleanPref(
98 prefs::kWebKitJavascriptCanOpenWindowsAutomatically, 99 prefs::kWebKitJavascriptCanOpenWindowsAutomatically,
99 true, 100 true,
100 PrefService::UNSYNCABLE_PREF); 101 PrefService::UNSYNCABLE_PREF);
101 prefs->RegisterBooleanPref(prefs::kWebKitLoadsImagesAutomatically, 102 prefs->RegisterBooleanPref(prefs::kWebKitLoadsImagesAutomatically,
102 pref_defaults.loads_images_automatically, 103 pref_defaults.loads_images_automatically,
103 PrefService::UNSYNCABLE_PREF); 104 PrefService::UNSYNCABLE_PREF);
105 prefs->RegisterBooleanPref(prefs::kWebKitImagesEnabled,
106 pref_defaults.images_enabled,
107 PrefService::UNSYNCABLE_PREF);
104 prefs->RegisterBooleanPref(prefs::kWebKitPluginsEnabled, 108 prefs->RegisterBooleanPref(prefs::kWebKitPluginsEnabled,
105 pref_defaults.plugins_enabled, 109 pref_defaults.plugins_enabled,
106 PrefService::UNSYNCABLE_PREF); 110 PrefService::UNSYNCABLE_PREF);
107 RegisterFontsAndCharsetPrefs(prefs); 111 RegisterFontsAndCharsetPrefs(prefs);
108 } 112 }
109 113
110 // The list of prefs we want to observe. 114 // The list of prefs we want to observe.
111 const char* kPrefsToObserve[] = { 115 const char* kPrefsToObserve[] = {
112 prefs::kDefaultZoomLevel, 116 prefs::kDefaultZoomLevel,
113 prefs::kGlobalDefaultCharset, 117 prefs::kGlobalDefaultCharset,
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 pref_store->RegisterOverlayPref( 390 pref_store->RegisterOverlayPref(
387 prefs::kWebKitJavascriptEnabled, 391 prefs::kWebKitJavascriptEnabled,
388 prefs::kWebKitGlobalJavascriptEnabled); 392 prefs::kWebKitGlobalJavascriptEnabled);
389 pref_store->RegisterOverlayPref( 393 pref_store->RegisterOverlayPref(
390 prefs::kWebKitJavascriptCanOpenWindowsAutomatically, 394 prefs::kWebKitJavascriptCanOpenWindowsAutomatically,
391 prefs::kWebKitGlobalJavascriptCanOpenWindowsAutomatically); 395 prefs::kWebKitGlobalJavascriptCanOpenWindowsAutomatically);
392 pref_store->RegisterOverlayPref( 396 pref_store->RegisterOverlayPref(
393 prefs::kWebKitLoadsImagesAutomatically, 397 prefs::kWebKitLoadsImagesAutomatically,
394 prefs::kWebKitGlobalLoadsImagesAutomatically); 398 prefs::kWebKitGlobalLoadsImagesAutomatically);
395 pref_store->RegisterOverlayPref( 399 pref_store->RegisterOverlayPref(
400 prefs::kWebKitImagesEnabled);
401 pref_store->RegisterOverlayPref(
396 prefs::kWebKitPluginsEnabled, 402 prefs::kWebKitPluginsEnabled,
397 prefs::kWebKitGlobalPluginsEnabled); 403 prefs::kWebKitGlobalPluginsEnabled);
398 pref_store->RegisterOverlayPref( 404 pref_store->RegisterOverlayPref(
399 prefs::kDefaultCharset, 405 prefs::kDefaultCharset,
400 prefs::kGlobalDefaultCharset); 406 prefs::kGlobalDefaultCharset);
401 pref_store->RegisterOverlayPref( 407 pref_store->RegisterOverlayPref(
402 prefs::kWebKitStandardFontFamily, 408 prefs::kWebKitStandardFontFamily,
403 prefs::kWebKitGlobalStandardFontFamily); 409 prefs::kWebKitGlobalStandardFontFamily);
404 pref_store->RegisterOverlayPref( 410 pref_store->RegisterOverlayPref(
405 prefs::kWebKitFixedFontFamily, 411 prefs::kWebKitFixedFontFamily,
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 RenderViewHostDelegate* rvhd = 610 RenderViewHostDelegate* rvhd =
605 web_contents()->GetRenderViewHost()->delegate(); 611 web_contents()->GetRenderViewHost()->delegate();
606 WebPreferences prefs = rvhd->GetWebkitPrefs(); 612 WebPreferences prefs = rvhd->GetWebkitPrefs();
607 prefs.javascript_enabled = 613 prefs.javascript_enabled =
608 per_tab_prefs_->GetBoolean(prefs::kWebKitJavascriptEnabled); 614 per_tab_prefs_->GetBoolean(prefs::kWebKitJavascriptEnabled);
609 prefs.javascript_can_open_windows_automatically = 615 prefs.javascript_can_open_windows_automatically =
610 per_tab_prefs_->GetBoolean( 616 per_tab_prefs_->GetBoolean(
611 prefs::kWebKitJavascriptCanOpenWindowsAutomatically); 617 prefs::kWebKitJavascriptCanOpenWindowsAutomatically);
612 prefs.loads_images_automatically = 618 prefs.loads_images_automatically =
613 per_tab_prefs_->GetBoolean(prefs::kWebKitLoadsImagesAutomatically); 619 per_tab_prefs_->GetBoolean(prefs::kWebKitLoadsImagesAutomatically);
620 prefs.images_enabled =
621 per_tab_prefs_->GetBoolean(prefs::kWebKitImagesEnabled);
614 prefs.plugins_enabled = 622 prefs.plugins_enabled =
615 per_tab_prefs_->GetBoolean(prefs::kWebKitPluginsEnabled); 623 per_tab_prefs_->GetBoolean(prefs::kWebKitPluginsEnabled);
616 prefs.standard_font_family = 624 prefs.standard_font_family =
617 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitStandardFontFamily)); 625 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitStandardFontFamily));
618 prefs.fixed_font_family = 626 prefs.fixed_font_family =
619 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitFixedFontFamily)); 627 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitFixedFontFamily));
620 prefs.serif_font_family = 628 prefs.serif_font_family =
621 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitSerifFontFamily)); 629 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitSerifFontFamily));
622 prefs.sans_serif_font_family = 630 prefs.sans_serif_font_family =
623 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitSansSerifFontFamily)); 631 UTF8ToUTF16(per_tab_prefs_->GetString(prefs::kWebKitSansSerifFontFamily));
(...skipping 17 matching lines...) Expand all
641 649
642 void PrefsTabHelper::UpdateRendererPreferences() { 650 void PrefsTabHelper::UpdateRendererPreferences() {
643 renderer_preferences_util::UpdateFromSystemSettings( 651 renderer_preferences_util::UpdateFromSystemSettings(
644 web_contents()->GetMutableRendererPrefs(), GetProfile()); 652 web_contents()->GetMutableRendererPrefs(), GetProfile());
645 web_contents()->GetRenderViewHost()->SyncRendererPrefs(); 653 web_contents()->GetRenderViewHost()->SyncRendererPrefs();
646 } 654 }
647 655
648 Profile* PrefsTabHelper::GetProfile() { 656 Profile* PrefsTabHelper::GetProfile() {
649 return Profile::FromBrowserContext(web_contents()->GetBrowserContext()); 657 return Profile::FromBrowserContext(web_contents()->GetBrowserContext());
650 } 658 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698