Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: ui/views/controls/textfield/native_textfield_views.cc

Issue 9250016: Aura: Add "Edit Search Engines" option to the aura omnibox context menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/native_textfield_views.cc
diff --git a/ui/views/controls/textfield/native_textfield_views.cc b/ui/views/controls/textfield/native_textfield_views.cc
index 2210052e35ca232f1bc0efbe57615cf12cd9d0ba..6d79789c5df51c2cf424946fef94aafdb98165e0 100644
--- a/ui/views/controls/textfield/native_textfield_views.cc
+++ b/ui/views/controls/textfield/native_textfield_views.cc
@@ -558,8 +558,7 @@ bool NativeTextfieldViews::IsCommandIdEnabled(int command_id) const {
case IDS_APP_SELECT_ALL:
return true;
default:
- NOTREACHED();
- return false;
+ return textfield_->GetController()->IsCommandIdEnabled(command_id);
}
}
@@ -592,7 +591,7 @@ void NativeTextfieldViews::ExecuteCommand(int command_id) {
SelectAll();
break;
default:
- NOTREACHED() << "unknown command: " << command_id;
+ textfield_->GetController()->ExecuteCommand(command_id);
break;
}
@@ -986,6 +985,8 @@ void NativeTextfieldViews::UpdateContextMenu() {
context_menu_contents_->AddSeparator();
context_menu_contents_->AddItemWithStringId(IDS_APP_SELECT_ALL,
IDS_APP_SELECT_ALL);
+ textfield_->GetController()->UpdateContextMenu(
+ context_menu_contents_.get());
context_menu_delegate_.reset(
new views::MenuModelAdapter(context_menu_contents_.get()));

Powered by Google App Engine
This is Rietveld 408576698