Aura: Add "Edit Search Engines" option to the aura omnibox context menu.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index b0f6ac270cce6b9eb580ecb7dfd5917835d1cf9d..b1483ee92babe34268a90bd5110e9d6e652a6d18 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -30,6 +30,7 @@
 #include "ui/base/dragdrop/os_exchange_data.h"
 #include "ui/base/ime/text_input_type.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/base/models/simple_menu_model.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/render_text.h"
@@ -715,6 +716,20 @@ void OmniboxViewViews::OnWriteDragData(ui::OSExchangeData* data) {
     data->SetURL(url, selected_text);
 }
 
+void OmniboxViewViews::UpdateContextMenu(ui::SimpleMenuModel* menu_contents) {
+  DCHECK(menu_contents);

[oshima, 2012/01/18 22:24:24]

you probably don't need this as it will crash on next line if it's NULL.

[varunjain, 2012/01/18 23:31:36]

Done.

+  menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
+      IDS_EDIT_SEARCH_ENGINES);
+}
+
+bool OmniboxViewViews::IsCommandIdEnabled(int command_id) const {
+  return command_updater_->IsCommandEnabled(command_id);

[oshima, 2012/01/18 22:24:24]

There is a known issue that views cannot use IDC_ and textfield is using IDS_
instead to deal with this issue. I don't expect collision will happen, but you
may add a comment that NativeTextfieldViews is using IDS_ while command_update_
is IDC_. Maybe we should file a bug to keep track of it and add reference here
and in textfield_views_model.cc

[varunjain, 2012/01/18 23:31:36]

Done.

+}
+
+void OmniboxViewViews::ExecuteCommand(int command_id) {
+  command_updater_->ExecuteCommand(command_id);
+}
+
 #if defined(OS_CHROMEOS)
 void OmniboxViewViews::CandidateWindowOpened(
       chromeos::input_method::InputMethodManager* manager) {