Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(180)

Issue 9240033: Use scoped_ptr<>.Pass() to pass ownership in the remoting protocol code. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov
Modified:
8 years, 8 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Use scoped_ptr<>.Pass() to pass ownership in the remoting protocol code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118407

Patch Set 1 #

Total comments: 21

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : - #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -249 lines) Patch
M remoting/protocol/authenticator.h View 1 2 4 chunks +9 lines, -7 lines 0 comments Download
M remoting/protocol/authenticator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_host.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/protocol/content_description.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/protocol/content_description.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M remoting/protocol/fake_authenticator.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 1 2 2 chunks +10 lines, -9 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_channel_connector.h View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_datagram_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_datagram_connector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 3 8 chunks +27 lines, -23 lines 3 comments Download
M remoting/protocol/jingle_session_manager.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 2 3 4 chunks +11 lines, -11 lines 3 comments Download
M remoting/protocol/jingle_session_unittest.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M remoting/protocol/jingle_stream_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_stream_connector.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 2 3 chunks +6 lines, -5 lines 2 comments Download
M remoting/protocol/pepper_channel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/pepper_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/pepper_session.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M remoting/protocol/pepper_session_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/pepper_session_manager.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/protocol/pepper_session_unittest.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M remoting/protocol/pepper_stream_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/pepper_stream_channel.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M remoting/protocol/session_config.h View 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/protocol/session_config.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M remoting/protocol/session_manager.h View 2 chunks +4 lines, -15 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/protocol/v1_authenticator.h View 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/protocol/v1_authenticator.cc View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download
M remoting/protocol/v1_authenticator_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/v2_authenticator.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M remoting/protocol/v2_authenticator.cc View 1 2 3 4 chunks +16 lines, -13 lines 0 comments Download
M remoting/protocol/v2_authenticator_unittest.cc View 1 6 chunks +12 lines, -11 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
I haven't update all code in remoting::protocol, just the Session/SessionManager interfaces and everything around their ...
8 years, 8 months ago (2012-01-18 00:06:43 UTC) #1
Wez
http://codereview.chromium.org/9240033/diff/1/remoting/protocol/jingle_session.h File remoting/protocol/jingle_session.h (right): http://codereview.chromium.org/9240033/diff/1/remoting/protocol/jingle_session.h#newcode111 remoting/protocol/jingle_session.h:111: static cricket::SessionDescription* CreateSessionDescription( Should the return-value be scoped_ptr<> managed ...
8 years, 8 months ago (2012-01-19 03:18:16 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/9240033/diff/1/remoting/protocol/jingle_session.h File remoting/protocol/jingle_session.h (right): http://codereview.chromium.org/9240033/diff/1/remoting/protocol/jingle_session.h#newcode111 remoting/protocol/jingle_session.h:111: static cricket::SessionDescription* CreateSessionDescription( On 2012/01/19 03:18:17, Wez wrote: > ...
8 years, 8 months ago (2012-01-19 20:11:41 UTC) #3
Wez
LGTM! http://codereview.chromium.org/9240033/diff/1/remoting/protocol/jingle_session.h File remoting/protocol/jingle_session.h (right): http://codereview.chromium.org/9240033/diff/1/remoting/protocol/jingle_session.h#newcode111 remoting/protocol/jingle_session.h:111: static cricket::SessionDescription* CreateSessionDescription( On 2012/01/19 20:11:42, sergeyu wrote: ...
8 years, 8 months ago (2012-01-19 23:23:40 UTC) #4
Sergey Ulanov
http://codereview.chromium.org/9240033/diff/1/remoting/protocol/v1_authenticator.cc File remoting/protocol/v1_authenticator.cc (right): http://codereview.chromium.org/9240033/diff/1/remoting/protocol/v1_authenticator.cc#newcode84 remoting/protocol/v1_authenticator.cc:84: return scoped_ptr<ChannelAuthenticator>(result.release()); On 2012/01/19 23:23:41, Wez wrote: > On ...
8 years, 8 months ago (2012-01-19 23:50:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9240033/9002
8 years, 8 months ago (2012-01-19 23:50:40 UTC) #6
Wez
http://codereview.chromium.org/9240033/diff/9002/remoting/protocol/jingle_session.cc File remoting/protocol/jingle_session.cc (right): http://codereview.chromium.org/9240033/diff/9002/remoting/protocol/jingle_session.cc#newcode67 remoting/protocol/jingle_session.cc:67: authenticator_->GetNextMessage()).release()); On 2012/01/19 23:50:26, sergeyu wrote: > On 2012/01/19 ...
8 years, 8 months ago (2012-01-19 23:56:57 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-01-20 03:31:33 UTC) #8
Try job failure for 9240033-9002 (retry) (retry) (retry) on mac_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698