Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: remoting/protocol/v2_authenticator.h

Issue 9240033: Use scoped_ptr<>.Pass() to pass ownership in the remoting protocol code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/v2_authenticator.h
diff --git a/remoting/protocol/v2_authenticator.h b/remoting/protocol/v2_authenticator.h
index 982823324a4f85ffa396a2aa8792b77281d576ed..01e8a67c2e898f1e76058c37906e25d012d13368 100644
--- a/remoting/protocol/v2_authenticator.h
+++ b/remoting/protocol/v2_authenticator.h
@@ -25,10 +25,10 @@ class V2Authenticator : public Authenticator {
public:
static bool IsEkeMessage(const buzz::XmlElement* message);
- static V2Authenticator* CreateForClient(
+ static scoped_ptr<Authenticator> CreateForClient(
const std::string& shared_secret);
- static V2Authenticator* CreateForHost(
+ static scoped_ptr<Authenticator> CreateForHost(
const std::string& local_cert,
const crypto::RSAPrivateKey& local_private_key,
const std::string& shared_secret);
@@ -38,8 +38,9 @@ class V2Authenticator : public Authenticator {
// Authenticator interface.
virtual State state() const OVERRIDE;
virtual void ProcessMessage(const buzz::XmlElement* message) OVERRIDE;
- virtual buzz::XmlElement* GetNextMessage() OVERRIDE;
- virtual ChannelAuthenticator* CreateChannelAuthenticator() const OVERRIDE;
+ virtual scoped_ptr<buzz::XmlElement> GetNextMessage() OVERRIDE;
+ virtual scoped_ptr<ChannelAuthenticator>
+ CreateChannelAuthenticator() const OVERRIDE;
private:
FRIEND_TEST_ALL_PREFIXES(V2AuthenticatorTest, InvalidSecret);

Powered by Google App Engine
This is Rietveld 408576698