Transition to base/mac/bundle_locations.h step 3

Transition to base/mac/bundle_locations.h step 3

Convert some instances of [NSBundle mainBundle] to equivalent calls in base/mac/bundle_locations.h

BUG=None
TEST=Code should compile and all unit tests should pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119030

[Mark Mentovai, 2012-01-17 16:49:07]

https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_in...
File chrome/browser/shell_integration_mac.mm (right):

https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_in...
chrome/browser/shell_integration_mac.mm:45: NSString* identifier =
[base::mac::MainBundle() bundleIdentifier];
Is it intentional that this file mixes OuterBundle and MainBundle?

[jeremy, 2012-01-17 19:12:58]

Yes, I was pretty careful about each usage but I may very well be wrong.

On Tue, Jan 17, 2012 at 6:49 PM, <mark@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/9240004/diff/1/**
>
chrome/browser/shell_**integration_mac.mm<https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_integration_mac.mm>
> File
chrome/browser/shell_**integration_mac.mm<http://shell_integration_mac.mm>(right):
>
> https://chromiumcodereview.**appspot.com/9240004/diff/1/**
>
chrome/browser/shell_**integration_mac.mm#newcode45<https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_integration_mac.mm#newcode45>
>
chrome/browser/shell_**integration_mac.mm:45<http://shell_integration_mac.mm:45>:
> NSString* identifier =
> [base::mac::MainBundle() bundleIdentifier];
> Is it intentional that this file mixes OuterBundle and MainBundle?
>
>
https://chromiumcodereview.**appspot.com/9240004/<https://chromiumcodereview....
>

[jeremy, 2012-01-19 16:10:26]

https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_in...
File chrome/browser/shell_integration_mac.mm (right):

https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_in...
chrome/browser/shell_integration_mac.mm:45: NSString* identifier =
[base::mac::MainBundle() bundleIdentifier];
Yes this is intentional, do you think the usage is correct?

[Mark Mentovai, 2012-01-19 16:48:53]

https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_in...
File chrome/browser/shell_integration_mac.mm (right):

https://chromiumcodereview.appspot.com/9240004/diff/1/chrome/browser/shell_in...
chrome/browser/shell_integration_mac.mm:45: NSString* identifier =
[base::mac::MainBundle() bundleIdentifier];
jeremy wrote:
> Yes this is intentional, do you think the usage is correct?

It could be, but it’s worth a comment. You should also fix the use of +[NSBundle
mainBundle] in IsDefaultProtocolClient.

[jeremy, 2012-01-23 07:05:03]

Added comments, ready for another look.

[Mark Mentovai, 2012-01-23 16:09:01]

LGTM

[jeremy, 2012-01-24 08:11:09]

Sky: Owner review needed for file in ui/ , rubberstamp OK, thanks!

[sky, 2012-01-24 16:53:49]

LGTM

[commit-bot: I haz the power, 2012-01-24 17:44:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/9240004/19001

[commit-bot: I haz the power, 2012-01-24 20:21:32]

Try job failure for 9240004-19001 (retry) on win_rel for steps "base_unittests,
unit_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-01-25 06:24:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/9240004/22001

[commit-bot: I haz the power, 2012-01-25 07:59:10]

Change committed as 119030