Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: Source/WebCore/rendering/svg/SVGRenderSupport.cpp

Issue 9235065: Merge 105978 - crash in WebCore::RenderSVGContainer::paint (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/rendering/svg/SVGInlineTextBox.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/svg/SVGRenderSupport.cpp
===================================================================
--- Source/WebCore/rendering/svg/SVGRenderSupport.cpp (revision 106008)
+++ Source/WebCore/rendering/svg/SVGRenderSupport.cpp (working copy)
@@ -87,8 +87,12 @@
const SVGRenderStyle* svgStyle = style->svgStyle();
ASSERT(svgStyle);
+ bool isRenderingMask = false;
+ if (object->frame() && object->frame()->view())
+ isRenderingMask = object->frame()->view()->paintBehavior() & PaintBehaviorRenderingSVGMask;
+
// Setup transparency layers before setting up SVG resources!
- float opacity = style->opacity();
+ float opacity = isRenderingMask ? 1 : style->opacity();
const ShadowData* shadow = svgStyle->shadow();
if (opacity < 1 || shadow) {
FloatRect repaintRect = object->repaintRectInLocalCoordinates();
@@ -114,9 +118,11 @@
return true;
}
- if (RenderSVGResourceMasker* masker = resources->masker()) {
- if (!masker->applyResource(object, style, paintInfo.context, ApplyToDefaultMode))
- return false;
+ if (!isRenderingMask) {
+ if (RenderSVGResourceMasker* masker = resources->masker()) {
+ if (!masker->applyResource(object, style, paintInfo.context, ApplyToDefaultMode))
+ return false;
+ }
}
if (RenderSVGResourceClipper* clipper = resources->clipper()) {
@@ -125,9 +131,11 @@
}
#if ENABLE(FILTERS)
- if (RenderSVGResourceFilter* filter = resources->filter()) {
- if (!filter->applyResource(object, style, paintInfo.context, ApplyToDefaultMode))
- return false;
+ if (!isRenderingMask) {
+ if (RenderSVGResourceFilter* filter = resources->filter()) {
+ if (!filter->applyResource(object, style, paintInfo.context, ApplyToDefaultMode))
+ return false;
+ }
}
#endif
« no previous file with comments | « Source/WebCore/rendering/svg/SVGInlineTextBox.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698