Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

Issue 9235065: Merge 105978 - crash in WebCore::RenderSVGContainer::paint (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
===================================================================
--- Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (revision 106008)
+++ Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (working copy)
@@ -198,21 +198,10 @@
const SVGRenderStyle* svgStyle = style->svgStyle();
ASSERT(svgStyle);
- bool hasFill = svgStyle->hasFill();
- bool hasStroke = svgStyle->hasStroke();
-
RenderStyle* selectionStyle = style;
if (hasSelection) {
selectionStyle = parentRenderer->getCachedPseudoStyle(SELECTION);
- if (selectionStyle) {
- const SVGRenderStyle* svgSelectionStyle = selectionStyle->svgStyle();
- ASSERT(svgSelectionStyle);
-
- if (!hasFill)
- hasFill = svgSelectionStyle->hasFill();
- if (!hasStroke)
- hasStroke = svgSelectionStyle->hasStroke();
- } else
+ if (!selectionStyle)
selectionStyle = style;
}
@@ -295,6 +284,11 @@
selectionStyle = style;
}
+ if (textRenderer->frame() && textRenderer->frame()->view() && textRenderer->frame()->view()->paintBehavior() & PaintBehaviorRenderingSVGMask) {
+ hasFill = true;
+ hasStroke = false;
+ }
+
AffineTransform fragmentTransform;
unsigned textFragmentsSize = m_textFragments.size();
for (unsigned i = 0; i < textFragmentsSize; ++i) {
« no previous file with comments | « Source/WebCore/rendering/svg/SVGImageBufferTools.cpp ('k') | Source/WebCore/rendering/svg/SVGRenderSupport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698