Detect errors in audio output and report them upstream.

content/renderer/media/audio_renderer_impl.cc

Index: content/renderer/media/audio_renderer_impl.cc
diff --git a/content/renderer/media/audio_renderer_impl.cc b/content/renderer/media/audio_renderer_impl.cc
index eb541867fc39434c80ac6ede4e94a25abe6b2883..bcde09288b2838a8449b09b9bb1758dba9e20e14 100644
--- a/content/renderer/media/audio_renderer_impl.cc
+++ b/content/renderer/media/audio_renderer_impl.cc
@@ -14,6 +14,7 @@
 #include "content/renderer/render_thread_impl.h"
 #include "media/audio/audio_buffers_state.h"
 #include "media/audio/audio_util.h"
+#include "media/base/filter_host.h"
 
 // We define GetBufferSizeForSampleRate() instead of using
 // GetAudioHardwareBufferSize() in audio_util because we're using
@@ -247,3 +248,8 @@ size_t AudioRendererImpl::Render(const std::vector<float*>& audio_data,
   }
   return filled_frames;
 }
+
+void AudioRendererImpl::OnError() {
+  if (host())

[scherkus (not reviewing), 2012/01/26 21:46:13]

nit: according to the superclass host() should always be valid

a crash would be preferable to a hang

[Ami GONE FROM CHROMIUM, 2012/01/26 22:11:01]

Done.
I wonder why we have these checks sprinkled, then?
http://code.google.com/p/chromium/source/search?q="if+(host())"

[scherkus (not reviewing), 2012/01/26 22:28:09]

AFAIK demuxers can execute w/o having a host present (at least chunkdemuxer can)
but the other ones are superfluous

+    host()->DisableAudioRenderer();
+}