Detect errors in audio output and report them upstream.

content/renderer/media/audio_renderer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/audio_renderer_impl.h"
 
 #include <math.h>
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "content/common/child_process.h"
 #include "content/common/media/audio_messages.h"
 #include "content/renderer/render_thread_impl.h"
 #include "media/audio/audio_buffers_state.h"
 #include "media/audio/audio_util.h"
+#include "media/base/filter_host.h"
 
 // We define GetBufferSizeForSampleRate() instead of using
 // GetAudioHardwareBufferSize() in audio_util because we're using
 // the AUDIO_PCM_LINEAR flag, instead of AUDIO_PCM_LOW_LATENCY,
 // which the audio_util functions assume.
 //
 // See: http://code.google.com/p/chromium/issues/detail?id=103627
 // for a more detailed description of the subtleties.
 static size_t GetBufferSizeForSampleRate(int sample_rate) {
   // kNominalBufferSize has been tested on Windows, Mac OS X, and Linux
@@ skipping 213 matching lines @@
     // If FillBuffer() didn't give us enough data then zero out the remainder.
     if (filled_frames < number_of_frames) {
       int frames_to_zero = number_of_frames - filled_frames;
       memset(audio_data[channel_index] + filled_frames,
              0,
              sizeof(float) * frames_to_zero);
     }
   }
   return filled_frames;
 }
+
+void AudioRendererImpl::OnError() {
+  if (host())

[scherkus (not reviewing), 2012/01/26 21:46:13]

nit: according to the superclass host() should always be valid

a crash would be preferable to a hang

[Ami GONE FROM CHROMIUM, 2012/01/26 22:11:01]

Done.
I wonder why we have these checks sprinkled, then?
http://code.google.com/p/chromium/source/search?q="if+(host())"

[scherkus (not reviewing), 2012/01/26 22:28:09]

AFAIK demuxers can execute w/o having a host present (at least chunkdemuxer can)
but the other ones are superfluous

+    host()->DisableAudioRenderer();
+}