Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 9234007: Cleanup trace_event.h, fix webkit API naming. (Closed)

Created:
8 years, 11 months ago by jbates
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup trace_event, fix webkit API naming. Remove unused TRACE_EVENT_API_ADD_COUNTER_EVENT and improve comments in trace_event.h. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118999

Patch Set 1 #

Patch Set 2 : removed BASE_EXPORT from inline TraceID #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M base/debug/trace_event.h View 1 3 chunks +14 lines, -14 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbates
8 years, 11 months ago (2012-01-24 23:12:57 UTC) #1
darin (slow to review)
OK, LGTM
8 years, 11 months ago (2012-01-25 00:53:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9234007/5
8 years, 11 months ago (2012-01-25 01:15:55 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 04:30:02 UTC) #4
Change committed as 118999

Powered by Google App Engine
This is Rietveld 408576698