Issue 9233050: Reduce memory use immediately after boot.

Issue 9233050: Reduce memory use immediately after boot. (Closed)

Created:
8 years, 10 months ago by Erik Corry

Modified:
8 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Reduce memory use immediately after boot. This is a recommit of https://chromiumcodereview.appspot.com/9289047 with changes noted in comments in the codereview tool. Committed: https://code.google.com/p/v8/source/detail?r=10562

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 6

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+447 lines, -212 lines)			Patch
M	src/deoptimizer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.cc	View		3 chunks	+18 lines, -2 lines	2 comments	Download
M	src/incremental-marking.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View		7 chunks	+15 lines, -11 lines	0 comments	Download
M	src/serialize.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/snapshot.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/spaces.h	View		24 chunks	+66 lines, -50 lines	0 comments	Download
M	src/spaces.cc	View	1 2	31 chunks	+267 lines, -88 lines	3 comments	Download
M	src/spaces-inl.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download
	src/store-buffer.cc	View		2 chunks	+50 lines, -36 lines	1 comment	Download
M	src/utils.h	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-spaces.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

Please review again. I have marked the places that are different from last time. https://chromiumcodereview.appspot.com/9233050/diff/1004/src/heap.cc ...

8 years, 10 months ago (2012-01-31 10:44:44 UTC) #2

Vyacheslav Egorov (Chromium)

8 years, 10 months ago (2012-01-31 11:21:22 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/9233050/diff/1004/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/9233050/diff/1004/src/heap.cc#newcode646
src/heap.cc:646: V8::FatalProcessOutOfMemory("Heap.:ReserveSpace");
accidental edit?

Expand Messages | Collapse Messages