Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9232033: Do not set checked mode unconditionally for Dartium (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add corresponding change to test.dart side. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/architecture.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 3bb4fdf8cebb298f83ceb00ba667812776436008..74c4297d0c67aa4d800bc3ccefcc59667d69cf0a 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -467,9 +467,11 @@ class StandardTestSuite implements TestSuite {
} else {
args = ['--no-timeout'];
if (component == 'dartium') {
- var dartFlags = ['--enable_asserts',
- '--enable_type_checks',
- '--ignore-unrecognized-flags'];
+ var dartFlags = ['--ignore-unrecognized-flags'];
+ if (configuration["checked"]) {
+ dartFlags.add('--enable_asserts');
+ dartFlags.add("--enable_type_checks");
+ }
dartFlags.addAll(vmOptions);
args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
}
« no previous file with comments | « tools/testing/architecture.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698