Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9232010: [uber page] Migrate all elements in the 'System' (cros) page to new locations. (Closed)

Created:
8 years, 11 months ago by csilv
Modified:
8 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Migrate all elements in the 'System' (cros) page to new locations. BUG=109214 TEST=Verify that settings formerly on the System page work on CrOS. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117954

Patch Set 1 : '' #

Total comments: 6

Patch Set 2 : review fixes, compile fix #

Patch Set 3 : rebase #

Patch Set 4 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+718 lines, -871 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/advanced_options.css View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/advanced_options.html View 1 2 3 chunks +75 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/advanced_options.js View 1 2 9 chunks +187 lines, -28 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.css View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.js View 1 2 10 chunks +57 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/keyboard_overlay.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/pointer_overlay.html View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/pointer_overlay.js View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/system_options.html View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/system_options.js View 1 2 1 chunk +0 lines, -260 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/system_options_page.css View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_handler2.h View 1 2 3 3 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_handler2.cc View 1 2 14 chunks +143 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.h View 1 2 6 chunks +43 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 1 2 7 chunks +105 lines, -4 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/system_options_handler2.h View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/system_options_handler2.cc View 1 2 1 chunk +0 lines, -272 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
csilv
+jhawkins for review There will be some followups to this to improve the CSS layout, ...
8 years, 11 months ago (2012-01-17 02:52:04 UTC) #1
James Hawkins
https://chromiumcodereview.appspot.com/9232010/diff/15006/chrome/browser/resources/options2/browser_options.js File chrome/browser/resources/options2/browser_options.js (right): https://chromiumcodereview.appspot.com/9232010/diff/15006/chrome/browser/resources/options2/browser_options.js#newcode545 chrome/browser/resources/options2/browser_options.js:545: it otherwise. @private, @param. Same for the method below ...
8 years, 11 months ago (2012-01-17 16:23:38 UTC) #2
csilv
https://chromiumcodereview.appspot.com/9232010/diff/15006/chrome/browser/resources/options2/browser_options.js File chrome/browser/resources/options2/browser_options.js (right): https://chromiumcodereview.appspot.com/9232010/diff/15006/chrome/browser/resources/options2/browser_options.js#newcode545 chrome/browser/resources/options2/browser_options.js:545: it otherwise. On 2012/01/17 16:23:39, James Hawkins wrote: > ...
8 years, 11 months ago (2012-01-17 17:58:49 UTC) #3
James Hawkins
8 years, 11 months ago (2012-01-17 18:05:51 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698