WebGL support.

WebGL support.


BUG=
TEST=

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=82

[Nikolay, 2012-01-17 15:24:01]

WebGL support diff against current tree.

[antonm, 2012-01-18 15:12:23]

1st round (sorry, huge CL)

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/DartUtilities.h:76: if (Dart_IsError(list)) {
nit: single line bodies are not put into {} in WebKit, please, run
check-webkit-style.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/DartUtilities.h:82: return result;
nit: indent (last nit regarding webkit-style)

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/DartUtilities.h:108: array.clear();
ASSERT(array.isEmpty())?

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h:115:
DartDOMWrapper::returnValue(args,
static_cast<ElementType>(receiver->item(index)));
do we need this static_cast, just double checking?

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/custom/DartFloat32ArrayCustom.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/custom/DartFloat32ArrayCustom.cpp:47:
WebCore::DartArrayBufferViewInternal::constructWebGLArray<Float32Array,
float>(args);
up to you, but I'd rather have a generic class DartArrayBufferViewInternal
parameterized by array class and element type and then all the methods would be
just static methods of this class.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp
(right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:506: //
FIXME: process Dart lists as parameters
nit: trailing dot is missing.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:132: if (exists
$overrideConstructorParameters{$dataNode->name}) {
this feels like a hack to me: if we change the order of generation
(implementation first, then interface), things will magically stop to work. 
Please, provide a helper which will return number of ctor parameters and will
support necessary custom logic.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:133:
$dataNode->extendedAttributes->{"ConstructorParameters"} =
$overrideConstructorParameters{$dataNode->name};
nit: please, omit "" around ConstructorParameters

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:235:
$dataNode->extendedAttributes->{"CanBeConstructed"} ||
HasCustomConstructor($dataNode);
nit: omit "" (here and below)

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/html/can...
File Source/WebCore/html/canvas/WebGLRenderingContext.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/html/can...
Source/WebCore/html/canvas/WebGLRenderingContext.idl:682: [StrictTypeChecking]
void         vertexAttribPointer(in unsigned long indx, in long size, in
unsigned long type, in boolean normalized,
please, rever whitespace only changes---they make diff harder to read.

[Nikolay, 2012-01-19 13:27:34]

Thanks for review, PTAL.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/DartUtilities.h:76: if (Dart_IsError(list)) {
On 2012/01/18 15:12:23, antonm wrote:
> nit: single line bodies are not put into {} in WebKit, please, run
> check-webkit-style.

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/DartUtilities.h:82: return result;
On 2012/01/18 15:12:23, antonm wrote:
> nit: indent (last nit regarding webkit-style)

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/DartUtilities.h:108: array.clear();
On 2012/01/18 15:12:23, antonm wrote:
> ASSERT(array.isEmpty())?

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h:115:
DartDOMWrapper::returnValue(args,
static_cast<ElementType>(receiver->item(index)));
Yes, we do.
On 2012/01/18 15:12:23, antonm wrote:
> do we need this static_cast, just double checking?

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/custom/DartFloat32ArrayCustom.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/custom/DartFloat32ArrayCustom.cpp:47:
WebCore::DartArrayBufferViewInternal::constructWebGLArray<Float32Array,
float>(args);
Thanks for proposal, I just think it's more uniform style.
 
On 2012/01/18 15:12:23, antonm wrote:
> up to you, but I'd rather have a generic class DartArrayBufferViewInternal
> parameterized by array class and element type and then all the methods would
be
> just static methods of this class.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp
(right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:506: //
FIXME: process Dart lists as parameters
On 2012/01/18 15:12:23, antonm wrote:
> nit: trailing dot is missing.

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
File Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:132: if (exists
$overrideConstructorParameters{$dataNode->name}) {
On 2012/01/18 15:12:23, antonm wrote:
> this feels like a hack to me: if we change the order of generation
> (implementation first, then interface), things will magically stop to work. 
> Please, provide a helper which will return number of ctor parameters and will
> support necessary custom logic.

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:133:
$dataNode->extendedAttributes->{"ConstructorParameters"} =
$overrideConstructorParameters{$dataNode->name};
On 2012/01/18 15:12:23, antonm wrote:
> nit: please, omit "" around ConstructorParameters

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/bindings...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:235:
$dataNode->extendedAttributes->{"CanBeConstructed"} ||
HasCustomConstructor($dataNode);
On 2012/01/18 15:12:23, antonm wrote:
> nit: omit "" (here and below)

Done.

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/html/can...
File Source/WebCore/html/canvas/WebGLRenderingContext.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/1/Source/WebCore/html/can...
Source/WebCore/html/canvas/WebGLRenderingContext.idl:682: [StrictTypeChecking]
void         vertexAttribPointer(in unsigned long indx, in long size, in
unsigned long type, in boolean normalized,
On 2012/01/18 15:12:23, antonm wrote:
> please, rever whitespace only changes---they make diff harder to read.

Done.

[antonm, 2012-01-19 14:05:49]

next round

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartDOMWrapper.h:452: class ParameterAdapter<
Vector<ElementType> > : public ParameterAdapterBase< Vector<ElementType > > {
nit: no need in space between ElementType and >

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:132: return
DartUtilities::toDouble(object);
I am not sure you can use those helpers, what if I pass something like [1, 'a']
into any GL function which uses those helpers?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:168: return
DartUtilities::toInteger(object);
What if I pass -1 into such a function?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.h:73: static Dart_Handle
vectorToDartList(const Vector<RefPtr<Element> >& vector)
nit: please, Vector< RefPtr<Element> >

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.h:81: return result;
nit: indent, didn't check-style catch it?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.h:87: static Dart_Handle
vectorToDartList(const Vector<Element >& vector)
nit: please, Vector<Element>

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h:58:
ParameterAdapter<Vector<ElementType> > list(arg1);
nit: < Vector

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp
(right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:96:
static Dart_Handle toDartValueInternal(const WebGLGetInfo& info)
do you need overloading here (see helper above)?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:121: //
FIXME: implement WebGLObjectArray
nit: trailing dot.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:121: //
FIXME: implement WebGLObjectArray
why you cannot implement it right now?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:636:
const ParameterAdapter<Float32Array, DartFloat32Array>
array(Dart_GetNativeArgument(args, 3));
FIXME: maybe process... is missing?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:122: sub
ConstructorParameters
please, provide less ambiguous name: ConstructorParameters look like a list of
parameters rather than number of them.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
File Source/WebCore/html/canvas/Float64Array.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
Source/WebCore/html/canvas/Float64Array.idl:40: Float64Array subarray(in
[Optional=CallWithDefaultValue] long start,
unnecessary change

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
File Source/WebCore/html/canvas/Int16Array.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
Source/WebCore/html/canvas/Int16Array.idl:39: Int16Array subarray(in
[Optional=CallWithDefaultValue] long start,
ditto

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
File Source/WebCore/html/canvas/Int32Array.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
Source/WebCore/html/canvas/Int32Array.idl:24: * OF THIS SOFTWARE, EVEN IF
ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
ditto (last time)

[Nikolay, 2012-01-19 15:08:45]

PTAL.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartDOMWrapper.h:452: class ParameterAdapter<
Vector<ElementType> > : public ParameterAdapterBase< Vector<ElementType > > {
On 2012/01/19 14:05:49, antonm wrote:
> nit: no need in space between ElementType and >

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:132: return
DartUtilities::toDouble(object);
On 2012/01/19 14:05:49, antonm wrote:
> I am not sure you can use those helpers, what if I pass something like [1,
'a']
> into any GL function which uses those helpers?

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:168: return
DartUtilities::toInteger(object);
c cast will apply. I think this behavior is natural.

On 2012/01/19 14:05:49, antonm wrote:
> What if I pass -1 into such a function?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.h:73: static Dart_Handle
vectorToDartList(const Vector<RefPtr<Element> >& vector)
On 2012/01/19 14:05:49, antonm wrote:
> nit: please, Vector< RefPtr<Element> >

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.h:81: return result;
Nope.

On 2012/01/19 14:05:49, antonm wrote:
> nit: indent, didn't check-style catch it?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.h:87: static Dart_Handle
vectorToDartList(const Vector<Element >& vector)
On 2012/01/19 14:05:49, antonm wrote:
> nit: please, Vector<Element>

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h:58:
ParameterAdapter<Vector<ElementType> > list(arg1);
On 2012/01/19 14:05:49, antonm wrote:
> nit: < Vector

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp
(right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:96:
static Dart_Handle toDartValueInternal(const WebGLGetInfo& info)
Done
On 2012/01/19 14:05:49, antonm wrote:
> do you need overloading here (see helper above)?

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:121: //
FIXME: implement WebGLObjectArray
On 2012/01/19 14:05:49, antonm wrote:
> nit: trailing dot.

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:121: //
FIXME: implement WebGLObjectArray
It's not implemented in V8.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp:636:
const ParameterAdapter<Float32Array, DartFloat32Array>
array(Dart_GetNativeArgument(args, 3));
On 2012/01/19 14:05:49, antonm wrote:
> FIXME: maybe process... is missing?

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/gyp/scripts/CodeGeneratorDart.pm:122: sub
ConstructorParameters
On 2012/01/19 14:05:49, antonm wrote:
> please, provide less ambiguous name: ConstructorParameters look like a list of
> parameters rather than number of them.

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
File Source/WebCore/html/canvas/Float64Array.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
Source/WebCore/html/canvas/Float64Array.idl:40: Float64Array subarray(in
[Optional=CallWithDefaultValue] long start,
On 2012/01/19 14:05:49, antonm wrote:
> unnecessary change

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
File Source/WebCore/html/canvas/Int16Array.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
Source/WebCore/html/canvas/Int16Array.idl:39: Int16Array subarray(in
[Optional=CallWithDefaultValue] long start,
On 2012/01/19 14:05:49, antonm wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
File Source/WebCore/html/canvas/Int32Array.idl (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/html/...
Source/WebCore/html/canvas/Int32Array.idl:24: * OF THIS SOFTWARE, EVEN IF
ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
On 2012/01/19 14:05:49, antonm wrote:
> ditto (last time)

Done.

[antonm, 2012-01-19 15:33:13]

Last round I think

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:168: return
DartUtilities::toInteger(object);
I don't think so, as in Dart numbers doesn't have fixed number of bits.  What
does JS do in those cases?

I think we should throw an exception.

On 2012/01/19 15:08:46, olonho wrote:
> c cast will apply. I think this behavior is natural.
> 
> On 2012/01/19 14:05:49, antonm wrote:
> > What if I pass -1 into such a function?
>

https://chromiumcodereview.appspot.com/9231022/diff/15031/Source/WebCore/bind...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/15031/Source/WebCore/bind...
Source/WebCore/bindings/dart/DartUtilities.cpp:130: double
DartUtilities::toNative<double>(Dart_Handle object, Dart_Handle& exception)
why not ParameterAdapter?

[Nikolay, 2012-01-20 11:38:37]

PTAL

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:168: return
DartUtilities::toInteger(object);
According to simple test in JS console this is behavior 
demonstrated by V8.

a = new Uint8Array(1)
Uint8Array
a[0] = -1
-1
a[0]
255

On 2012/01/19 15:33:13, antonm wrote:
> I don't think so, as in Dart numbers doesn't have fixed number of bits.  What
> does JS do in those cases?
> 
> I think we should throw an exception.
> 
> On 2012/01/19 15:08:46, olonho wrote:
> > c cast will apply. I think this behavior is natural.
> > 
> > On 2012/01/19 14:05:49, antonm wrote:
> > > What if I pass -1 into such a function?
> > 
>

https://chromiumcodereview.appspot.com/9231022/diff/15031/Source/WebCore/bind...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/15031/Source/WebCore/bind...
Source/WebCore/bindings/dart/DartUtilities.cpp:130: double
DartUtilities::toNative<double>(Dart_Handle object, Dart_Handle& exception)
Because it's not a parameter, and I wanted more explicit 
conversion. 

On 2012/01/19 15:33:13, antonm wrote:
> why not ParameterAdapter?

[antonm, 2012-01-20 17:35:57]

LGTM modulo unsigned conversion.

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
File Source/WebCore/bindings/dart/DartUtilities.cpp (right):

https://chromiumcodereview.appspot.com/9231022/diff/8001/Source/WebCore/bindi...
Source/WebCore/bindings/dart/DartUtilities.cpp:168: return
DartUtilities::toInteger(object);
Thanks a lot for verifying how JS works.

However, I don't think we should keep this logic in such a general place as
DartUtilities, please, keep it in WebGL related parts and name accordingly.

On 2012/01/20 11:38:37, olonho wrote:
> According to simple test in JS console this is behavior 
> demonstrated by V8.
> 
> a = new Uint8Array(1)
> Uint8Array
> a[0] = -1
> -1
> a[0]
> 255
> 
> On 2012/01/19 15:33:13, antonm wrote:
> > I don't think so, as in Dart numbers doesn't have fixed number of bits. 
What
> > does JS do in those cases?
> > 
> > I think we should throw an exception.
> > 
> > On 2012/01/19 15:08:46, olonho wrote:
> > > c cast will apply. I think this behavior is natural.
> > > 
> > > On 2012/01/19 14:05:49, antonm wrote:
> > > > What if I pass -1 into such a function?
> > > 
> > 
>