Issue 9226040: Renames and moves some workspace related classes to the workspace

Issue 9226040: Renames and moves some workspace related classes to the workspace (Closed)

Created:
8 years, 11 months ago by sky

Modified:
8 years, 11 months ago

Reviewers:
oshima, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Renames and moves some workspace related classes to the workspace directory. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118620

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -867 lines)			Patch
M	ash/ash.gyp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/shell.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
D	ash/wm/default_container_event_filter.h	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	ash/wm/default_container_event_filter.cc	View	1 chunk	+0 lines, -131 lines	0 comments	Download
D	ash/wm/default_container_layout_manager.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	ash/wm/default_container_layout_manager.cc	View	1 chunk	+0 lines, -190 lines	0 comments	Download
D	ash/wm/default_container_layout_manager_unittest.cc	View	1 chunk	+0 lines, -341 lines	0 comments	Download
A +	ash/wm/workspace/workspace_event_filter.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
A +	ash/wm/workspace/workspace_event_filter.cc	View	4 chunks	+11 lines, -11 lines	0 comments	Download
A +	ash/wm/workspace/workspace_layout_manager.h	View	3 chunks	+8 lines, -9 lines	0 comments	Download
A +	ash/wm/workspace/workspace_layout_manager.cc	View	7 chunks	+16 lines, -16 lines	0 comments	Download
A +	ash/wm/workspace/workspace_layout_manager_unittest.cc	View	13 chunks	+18 lines, -18 lines	0 comments	Download
M	ash/wm/workspace_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm On Fri, Jan 20, 2012 at 4:24 PM, <ben@chromium.org> wrote: > lgtm > > ...

8 years, 11 months ago (2012-01-21 00:32:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9226040/1

8 years, 11 months ago (2012-01-21 00:38:35 UTC) #4

commit-bot: I haz the power

8 years, 11 months ago (2012-01-21 00:38:39 UTC) #5

Can't apply patch for file ash/wm/workspace/workspace_event_filter.cc.
While running patch -p0 --forward --force;
patching file ash/wm/workspace/workspace_event_filter.cc
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 31.
Hunk #3 FAILED at 95.
Hunk #4 FAILED at 118.
4 out of 4 hunks FAILED -- saving rejects to file
ash/wm/workspace/workspace_event_filter.cc.rej

Expand Messages | Collapse Messages