Index: net/socket/client_socket_pool_base.h |
diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h |
index 0cca6f4aa721ca78a370f4ed72fcc944f5b937c7..4efb43d0e7f52fabec79247f5258ad2f76834d15 100644 |
--- a/net/socket/client_socket_pool_base.h |
+++ b/net/socket/client_socket_pool_base.h |
@@ -1,4 +1,4 @@ |
-// Copyright (c) 2011 The Chromium Authors. All rights reserved. |
+// Copyright (c) 2012 The Chromium Authors. All rights reserved. |
// Use of this source code is governed by a BSD-style license that can be |
// found in the LICENSE file. |
// |
@@ -28,7 +28,6 @@ |
#include <map> |
#include <set> |
#include <string> |
-#include <vector> |
#include "base/basictypes.h" |
#include "base/memory/ref_counted.h" |
@@ -240,11 +239,6 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
virtual ~ClientSocketPoolBaseHelper(); |
- // Adds/Removes layered pools. It is expected in the destructor that no |
- // layered pools remain. |
- void AddLayeredPool(LayeredPool* pool); |
- void RemoveLayeredPool(LayeredPool* pool); |
- |
// See ClientSocketPool::RequestSocket for documentation on this function. |
// ClientSocketPoolBaseHelper takes ownership of |request|, which must be |
// heap allocated. |
@@ -267,9 +261,6 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
// See ClientSocketPool::Flush for documentation on this function. |
void Flush(); |
- // See ClientSocketPool::IsStalled for documentation on this function. |
- bool IsStalled() const; |
- |
// See ClientSocketPool::CloseIdleSockets for documentation on this function. |
void CloseIdleSockets(); |
@@ -314,16 +305,6 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
// sockets that timed out or can't be reused. Made public for testing. |
void CleanupIdleSockets(bool force); |
- // Closes one idle socket. Picks the first one encountered. |
- // TODO(willchan): Consider a better algorithm for doing this. Perhaps we |
- // should keep an ordered list of idle sockets, and close them in order. |
- // Requires maintaining more state. It's not clear if it's worth it since |
- // I'm not sure if we hit this situation often. |
- bool CloseOneIdleSocket(); |
- |
- // Checks layered pools to see if they can close an idle connection. |
- bool CloseOneIdleConnectionInLayeredPool(); |
- |
// See ClientSocketPool::GetInfoAsValue for documentation on this function. |
base::DictionaryValue* GetInfoAsValue(const std::string& name, |
const std::string& type) const; |
@@ -477,7 +458,7 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
// at least one pending request. Returns true if any groups are stalled, and |
// if so, fills |group| and |group_name| with data of the stalled group |
// having highest priority. |
- bool FindTopStalledGroup(Group** group, std::string* group_name) const; |
+ bool FindTopStalledGroup(Group** group, std::string* group_name); |
// Called when timer_ fires. This method scans the idle sockets removing |
// sockets that timed out or can't be reused. |
@@ -529,6 +510,13 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
static void LogBoundConnectJobToRequest( |
const NetLog::Source& connect_job_source, const Request* request); |
+ // Closes one idle socket. Picks the first one encountered. |
+ // TODO(willchan): Consider a better algorithm for doing this. Perhaps we |
+ // should keep an ordered list of idle sockets, and close them in order. |
+ // Requires maintaining more state. It's not clear if it's worth it since |
+ // I'm not sure if we hit this situation often. |
+ void CloseOneIdleSocket(); |
+ |
// Same as CloseOneIdleSocket() except it won't close an idle socket in |
// |group|. If |group| is NULL, it is ignored. Returns true if it closed a |
// socket. |
@@ -593,8 +581,6 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
// make sure that they are discarded rather than reused. |
int pool_generation_number_; |
- std::set<LayeredPool*> higher_layer_pools_; |
- |
base::WeakPtrFactory<ClientSocketPoolBaseHelper> weak_factory_; |
DISALLOW_COPY_AND_ASSIGN(ClientSocketPoolBaseHelper); |
@@ -661,13 +647,6 @@ class ClientSocketPoolBase { |
virtual ~ClientSocketPoolBase() {} |
// These member functions simply forward to ClientSocketPoolBaseHelper. |
- void AddLayeredPool(LayeredPool* pool) { |
- helper_.AddLayeredPool(pool); |
- } |
- |
- void RemoveLayeredPool(LayeredPool* pool) { |
- helper_.RemoveLayeredPool(pool); |
- } |
// RequestSocket bundles up the parameters into a Request and then forwards to |
// ClientSocketPoolBaseHelper::RequestSocket(). |
@@ -712,10 +691,6 @@ class ClientSocketPoolBase { |
return helper_.ReleaseSocket(group_name, socket, id); |
} |
- void Flush() { helper_.Flush(); } |
- |
- bool IsStalled() const { return helper_.IsStalled(); } |
- |
void CloseIdleSockets() { return helper_.CloseIdleSockets(); } |
int idle_socket_count() const { return helper_.idle_socket_count(); } |
@@ -764,11 +739,7 @@ class ClientSocketPoolBase { |
void EnableConnectBackupJobs() { helper_.EnableConnectBackupJobs(); } |
- bool CloseOneIdleSocket() { return helper_.CloseOneIdleSocket(); } |
- |
- bool CloseOneIdleConnectionInLayeredPool() { |
- return helper_.CloseOneIdleConnectionInLayeredPool(); |
- } |
+ void Flush() { helper_.Flush(); } |
private: |
// This adaptor class exists to bridge the |