Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9221014: aura: Gesture event plumbing (skeleton). (Closed)

Created:
8 years, 11 months ago by sadrul
Modified:
8 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, jam, penghuang+watch_chromium.org, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, James Su
Visibility:
Public.

Description

aura: Gesture event plumbing (skeleton). Add gesture event plumbing through aura. This is not functional just yet. Subsequent CLs will move the gesture-recognizer from views into aura, which will then generate and deliver aura gesture events. BUG=11024 TEST=no functional changes yet. Tests will be added when GR is moved into aura. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117911

Patch Set 1 #

Patch Set 2 : . #

Total comments: 16

Patch Set 3 : . #

Patch Set 4 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -22 lines) Patch
M ash/accelerators/accelerator_filter.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M ash/app_list/app_list.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/app_list/app_list.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/ime/input_method_event_filter.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ash/ime/input_method_event_filter.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/wm/modality_event_filter.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ash/wm/modality_event_filter.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M ash/wm/root_window_event_filter.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ash/wm/root_window_event_filter.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M ash/wm/window_modality_controller.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/window_modality_controller.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ui/aura/event.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ui/aura/event_filter.h View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M ui/aura/event_filter_unittest.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ui/aura/root_window.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M ui/aura/test/test_event_filter.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/test/test_event_filter.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M ui/aura/window_delegate.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
8 years, 11 months ago (2012-01-17 15:57:53 UTC) #1
sky
LGTM http://codereview.chromium.org/9221014/diff/1037/ash/accelerators/accelerator_filter.h File ash/accelerators/accelerator_filter.h (right): http://codereview.chromium.org/9221014/diff/1037/ash/accelerators/accelerator_filter.h#newcode31 ash/accelerators/accelerator_filter.h:31: virtual ui::GestureStatus PreHandleGestureEvent(aura::Window* target, nit: put this param ...
8 years, 11 months ago (2012-01-17 17:18:34 UTC) #2
sadrul
8 years, 11 months ago (2012-01-17 17:25:36 UTC) #3 
Thanks for the quick review!

http://codereview.chromium.org/9221014/diff/1037/ash/accelerators/accelerator...
File ash/accelerators/accelerator_filter.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/accelerators/accelerator...
ash/accelerators/accelerator_filter.h:31: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put this param on its own line so that indentation matches that of 32.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/app_list/app_list.h
File ash/app_list/app_list.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/app_list/app_list.h#newc...
ash/app_list/app_list.h:53: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> put on next line.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/drag_drop/drag_drop_cont...
File ash/drag_drop/drag_drop_controller.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/drag_drop/drag_drop_cont...
ash/drag_drop/drag_drop_controller.h:65: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put on next line.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/ime/input_method_event_f...
File ash/ime/input_method_event_filter.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/ime/input_method_event_f...
ash/ime/input_method_event_filter.h:41: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put on next line.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/wm/root_window_event_fil...
File ash/wm/root_window_event_filter.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/wm/root_window_event_fil...
ash/wm/root_window_event_filter.h:43: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put on next line.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/wm/toplevel_window_event...
File ash/wm/toplevel_window_event_filter.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/wm/toplevel_window_event...
ash/wm/toplevel_window_event_filter.h:41: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put param on next line.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/wm/window_cycle_controll...
File ash/wm/window_cycle_controller.cc (right):

http://codereview.chromium.org/9221014/diff/1037/ash/wm/window_cycle_controll...
ash/wm/window_cycle_controller.cc:30: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put param on next line.

Done.

http://codereview.chromium.org/9221014/diff/1037/ash/wm/window_modality_contr...
File ash/wm/window_modality_controller.h (right):

http://codereview.chromium.org/9221014/diff/1037/ash/wm/window_modality_contr...
ash/wm/window_modality_controller.h:34: virtual ui::GestureStatus
PreHandleGestureEvent(aura::Window* target,
On 2012/01/17 17:18:35, sky wrote:
> nit: put on next line.

Done.

Powered by Google App Engine
This is Rietveld 408576698