Fix DirectX diagnostic collection for about:gpu page.

Fix DirectX diagnostic collection for about:gpu page.

The DirectX diagnostics are collected by a separate GPU process that is not sandboxed. This is because the sandbox prevents them from being collected.

[apatrick_chromium, 2012-01-24 19:01:04]

Can you look at the inline comment and let me know what I should do? Thanks.

https://chromiumcodereview.appspot.com/9212054/diff/4002/content/browser/gpu/...
File content/browser/gpu/gpu_data_manager.cc (right):

https://chromiumcodereview.appspot.com/9212054/diff/4002/content/browser/gpu/...
content/browser/gpu/gpu_data_manager.cc:253: complete_gpu_info_available_ =
gpu_info.finalized;
these are probably wrong. perhaps once they have become true, they should stay
that way?

[Zhenyao Mo, 2012-01-24 19:15:33]

LGTM (please fix the nit)

https://chromiumcodereview.appspot.com/9212054/diff/4002/content/browser/gpu/...
File content/browser/gpu/gpu_data_manager.cc (right):

https://chromiumcodereview.appspot.com/9212054/diff/4002/content/browser/gpu/...
content/browser/gpu/gpu_data_manager.cc:253: complete_gpu_info_available_ =
gpu_info.finalized;
On 2012/01/24 19:01:04, apatrick_chromium wrote:
> these are probably wrong. perhaps once they have become true, they should stay
> that way?

Yes, this should be

complete_gpu_info_available_ = complete_gpu_info_available_ ||
gpu_info.finalized;
complete_gpu_info_already_requested_ = complete_gpu_info_already_requested_ ||
gpu_info.finalized;

[apatrick_chromium, 2012-01-24 21:54:52]

cpu: can you check the change in sandbox_policy.cc (it was using the browser's
command line instead of the GPU process' command line to look for
--disable-gpu-sandbox).

jam: owners for the above.

[apatrick_chromium, 2012-01-25 20:59:46]

On 2012/01/24 21:54:52, apatrick_chromium wrote:
> cpu: can you check the change in sandbox_policy.cc (it was using the browser's
> command line instead of the GPU process' command line to look for
> --disable-gpu-sandbox).
> 
> jam: owners for the above.

cpu, jam, ping.

[jam, 2012-01-25 21:37:32]

On 2012/01/25 20:59:46, apatrick_chromium wrote:
> On 2012/01/24 21:54:52, apatrick_chromium wrote:
> > cpu: can you check the change in sandbox_policy.cc (it was using the
browser's
> > command line instead of the GPU process' command line to look for
> > --disable-gpu-sandbox).
> > 
> > jam: owners for the above.
> 
> cpu, jam, ping.

content/common lgtm, sorry for the delay (just saw this)

[cpu_(ooo_6.6-7.5), 2012-01-26 04:24:52]

lgtm