Fix DirectX diagnostic collection for about:gpu page.

content/browser/gpu/gpu_data_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_data_manager.h"
 
 #if defined(OS_MACOSX)
 #include <CoreGraphics/CGDisplayConfiguration.h>
 #endif
 
@@ skipping 232 matching lines @@
 
   GpuProcessHost::SendOnIO(
       0,
       content::CAUSE_FOR_GPU_LAUNCH_GPUDATAMANAGER_REQUESTCOMPLETEGPUINFOIFNEEDED,
       new GpuMsg_CollectGraphicsInfo());
 }
 
 void GpuDataManager::UpdateGpuInfo(const content::GPUInfo& gpu_info) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  complete_gpu_info_available_ = true;
-  complete_gpu_info_already_requested_ = true;
+  complete_gpu_info_available_ = gpu_info.finalized;

[apatrick_chromium, 2012/01/24 19:01:04]

these are probably wrong. perhaps once they have become true, they should stay
that way?

[Zhenyao Mo, 2012/01/24 19:15:33]

Yes, this should be

complete_gpu_info_available_ = complete_gpu_info_available_ ||
gpu_info.finalized;
complete_gpu_info_already_requested_ = complete_gpu_info_already_requested_ ||
gpu_info.finalized;

+  complete_gpu_info_already_requested_ = gpu_info.finalized;
   {
     base::AutoLock auto_lock(gpu_info_lock_);
     if (!Merge(&gpu_info_, gpu_info))
       return;
     content::GetContentClient()->SetGpuInfo(gpu_info_);
   }
 
   UpdateGpuFeatureFlags();
   // We have to update GpuFeatureFlags before notify all the observers.
   NotifyGpuInfoUpdate();
@@ skipping 494 matching lines @@
 bool GpuDataManager::supportsAccelerated2dCanvas() const {
   if (gpu_info_.can_lose_context)
     return false;
 #if defined(USE_SKIA)
   return true;
 #else
   return false;
 #endif
 }