Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 9212045: Do not follow accessor map transitions when marking descriptor arrays. (Closed)

Created:
8 years, 11 months ago by Sven Panne
Modified:
8 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Do not follow accessor map transitions when marking descriptor arrays. Note that we currently have no such transitions, but we will in the future, and we have to avoid keeping maps live too long. Committed: https://code.google.com/p/v8/source/detail?r=10495

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated online and offline feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -18 lines) Patch
M src/mark-compact.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 1 2 chunks +38 lines, -18 lines 0 comments Download
M src/mark-compact-inl.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
8 years, 11 months ago (2012-01-24 13:01:16 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/9212045/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/9212045/diff/1/src/mark-compact.cc#newcode1675 src/mark-compact.cc:1675: bool MarkCompactCollector::MarkUnmarked(Object* value) { The name is kind of ...
8 years, 11 months ago (2012-01-24 13:28:29 UTC) #2
Sven Panne
Incorporated online and offline comments/suggestions. PTAL...
8 years, 11 months ago (2012-01-24 16:08:11 UTC) #3
Michael Starzinger
8 years, 11 months ago (2012-01-25 08:45:48 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698