Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: src/mark-compact.h

Issue 9212045: Do not follow accessor map transitions when marking descriptor arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated online and offline feedback Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 621
622 // Marking operations for objects reachable from roots. 622 // Marking operations for objects reachable from roots.
623 void MarkLiveObjects(); 623 void MarkLiveObjects();
624 624
625 void AfterMarking(); 625 void AfterMarking();
626 626
627 // Marks the object black and pushes it on the marking stack. 627 // Marks the object black and pushes it on the marking stack.
628 // This is for non-incremental marking. 628 // This is for non-incremental marking.
629 INLINE(void MarkObject(HeapObject* obj, MarkBit mark_bit)); 629 INLINE(void MarkObject(HeapObject* obj, MarkBit mark_bit));
630 630
631 INLINE(bool MarkObjectWithoutPush(HeapObject* object));
632 INLINE(void MarkObjectAndPush(HeapObject* value));
633
631 // Marks the object black. This is for non-incremental marking. 634 // Marks the object black. This is for non-incremental marking.
632 INLINE(void SetMark(HeapObject* obj, MarkBit mark_bit)); 635 INLINE(void SetMark(HeapObject* obj, MarkBit mark_bit));
633 636
634 // Clears the cache of ICs related to this map. 637 // Clears the cache of ICs related to this map.
635 INLINE(void ClearCacheOnMap(Map* map)); 638 INLINE(void ClearCacheOnMap(Map* map));
636 639
637 void ProcessNewlyMarkedObject(HeapObject* obj); 640 void ProcessNewlyMarkedObject(HeapObject* obj);
638 641
639 // Creates back pointers for all map transitions, stores them in 642 // Creates back pointers for all map transitions, stores them in
640 // the prototype field. The original prototype pointers are restored 643 // the prototype field. The original prototype pointers are restored
641 // in ClearNonLiveTransitions(). All JSObject maps 644 // in ClearNonLiveTransitions(). All JSObject maps
642 // connected by map transitions have the same prototype object, which 645 // connected by map transitions have the same prototype object, which
643 // is why we can use this field temporarily for back pointers. 646 // is why we can use this field temporarily for back pointers.
644 void CreateBackPointers(); 647 void CreateBackPointers();
645 648
646 // Mark a Map and its DescriptorArray together, skipping transitions. 649 // Mark a Map and its DescriptorArray together, skipping transitions.
647 void MarkMapContents(Map* map); 650 void MarkMapContents(Map* map);
651 void MarkAccessorPairSlot(HeapObject* accessors, int offset);
648 void MarkDescriptorArray(DescriptorArray* descriptors); 652 void MarkDescriptorArray(DescriptorArray* descriptors);
649 653
650 // Mark the heap roots and all objects reachable from them. 654 // Mark the heap roots and all objects reachable from them.
651 void MarkRoots(RootMarkingVisitor* visitor); 655 void MarkRoots(RootMarkingVisitor* visitor);
652 656
653 // Mark the symbol table specially. References to symbols from the 657 // Mark the symbol table specially. References to symbols from the
654 // symbol table are weak. 658 // symbol table are weak.
655 void MarkSymbolTable(); 659 void MarkSymbolTable();
656 660
657 // Mark objects in object groups that have at least one object in the 661 // Mark objects in object groups that have at least one object in the
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 757
754 friend class Heap; 758 friend class Heap;
755 }; 759 };
756 760
757 761
758 const char* AllocationSpaceName(AllocationSpace space); 762 const char* AllocationSpaceName(AllocationSpace space);
759 763
760 } } // namespace v8::internal 764 } } // namespace v8::internal
761 765
762 #endif // V8_MARK_COMPACT_H_ 766 #endif // V8_MARK_COMPACT_H_
OLDNEW
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698