Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 9193015: Further robustify the keyed lookup cache against unlucky hash (Closed)

Created:
8 years, 11 months ago by Erik Corry
Modified:
8 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Further robustify the keyed lookup cache against unlucky hash seeds. This change is performance neutral on most snapshot VM builds, but provides a big improvement on string-fasta on around 5% of builds. Committed: https://code.google.com/p/v8/source/detail?r=10478

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -123 lines) Patch
M src/arm/ic-arm.cc View 2 chunks +33 lines, -26 lines 0 comments Download
M src/heap.h View 1 chunk +3 lines, -3 lines 1 comment Download
M src/heap.cc View 2 chunks +27 lines, -15 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +34 lines, -25 lines 0 comments Download
M src/mips/ic-mips.cc View 2 chunks +27 lines, -27 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +34 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 11 months ago (2012-01-23 15:27:23 UTC) #1
Yang
8 years, 11 months ago (2012-01-23 15:53:31 UTC) #2
Assuming that there is no generated code equivalent to KeyedLookupCache::Update,
this LGTM with one small comment.

https://chromiumcodereview.appspot.com/9193015/diff/1/src/heap.h
File src/heap.h (right):

https://chromiumcodereview.appspot.com/9193015/diff/1/src/heap.h#newcode2142
src/heap.h:2142: static const int kEntriesPerBucket = 4;
Maybe add assertions such as
STATIC_ASSERT(IS_POWER_OF_TWO(kEntriesPerBucket));
STATIC_ASSERT(kHashMask == -kEntriesPerBucket)

Powered by Google App Engine
This is Rietveld 408576698