src/heap.h - Issue 9193015: Further robustify the keyed lookup cache against unlucky hash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.h

Issue 9193015: Further robustify the keyed lookup cache against unlucky hash (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.h

===================================================================

--- src/heap.h (revision 10474)

+++ src/heap.h (working copy)

@@ -2135,11 +2135,11 @@

// Clear the cache.

void Clear();

- static const int kLength = 128;

+ static const int kLength = 256;

static const int kCapacityMask = kLength - 1;

static const int kMapHashShift = 5;

- static const int kHashMask = -2; // Zero the last bit.

- static const int kEntriesPerBucket = 2;

+ static const int kHashMask = -4; // Zero the last two bits.

+ static const int kEntriesPerBucket = 4;

Yang 2012/01/23 15:53:31 Maybe add assertions such as STATIC_ASSERT(IS_POWE

static const int kNotFound = -1;

private:

« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/heap.cc » ('j') | no next file with comments »