Disable harmless warnings for 3rdparty code: ICU.

icu.gyp

Index: icu.gyp
===================================================================
--- icu.gyp	(revision 113543)
+++ icu.gyp	(working copy)
@@ -283,7 +283,7 @@
             ['OS == "mac"', {
               'xcode_settings': {
                 'GCC_ENABLE_CPP_RTTI': 'YES',       # -frtti
-              }
+              },
             }],
             ['OS == "win"', {
               'msvs_settings': {
@@ -320,6 +320,27 @@
                 }],
               ],
             }],
+            ['clang==1', {
+              'xcode_settings': {
+                'WARNING_CFLAGS': [
+                  # ICU uses its own deprecated functions.
+                  '-Wno-deprecated-declarations',
+                  # ICU prefers `a && b || c` over `(a && b) || c`.
+                  '-Wno-logical-op-parentheses',
+                  # ICU has some `unsigned < 0` checks.
+                  '-Wno-tautological-compare',
+                  # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
+                  # the header should use U_NAMESPACE_BEGIN instead.
+                  '-Wno-header-hygiene',

[Evan Martin, 2012/01/17 19:12:54]

This one makes me sad.  It's spotting a real bug.

+                ],
+              },
+              'cflags': [
+                '-Wno-deprecated-declarations',
+                '-Wno-logical-op-parentheses',
+                '-Wno-tautological-compare',
+                '-Wno-header-hygiene',
+              ],
+            }],
           ],
         },
         {
@@ -524,7 +545,7 @@
             ['OS == "mac"', {
               'xcode_settings': {
                 'GCC_ENABLE_CPP_RTTI': 'YES',       # -frtti
-              }
+              },
             }],
             ['OS == "win"', {
               'msvs_settings': {
@@ -561,6 +582,23 @@
                 }],
               ],
             }],
+            ['clang==1', {
+              'xcode_settings': {
+                'WARNING_CFLAGS': [
+                  # ICU uses its own deprecated functions.
+                  '-Wno-deprecated-declarations',
+                  # ICU prefers `a && b || c` over `(a && b) || c`.
+                  '-Wno-logical-op-parentheses',
+                  # ICU has some `unsigned < 0` checks.
+                  '-Wno-tautological-compare',
+                ],
+              },
+              'cflags': [
+                '-Wno-deprecated-declarations',
+                '-Wno-logical-op-parentheses',
+                '-Wno-tautological-compare',
+              ],
+            }],
           ],
         },
       ],