Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: scripts/master/factory/chromium_commands.py

Issue 9138042: Adds a 'webkit_lint' test step to the bots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/factory/chromium_commands.py
===================================================================
--- scripts/master/factory/chromium_commands.py (revision 118512)
+++ scripts/master/factory/chromium_commands.py (working copy)
@@ -745,6 +745,15 @@
test_command=cmd,
do_step_if=self.TestStepFilter)
+ def AddWebkitLint(self, factory_properties=None):
+ """Adds a step to the factory to lint the WebKit test_expectations.txt file."""
nsylvain 2012/01/25 20:19:54 80 chars
Dirk Pranke 2012/01/25 22:39:07 Done.
+ factory_properties = factory_properties or {}
nsylvain 2012/01/25 20:19:54 i dont think you need this line
Dirk Pranke 2012/01/25 22:39:07 Done.
+ cmd = [self._python, self._lint_test_files_tool]
+ self.AddTestStep(shell.ShellCommand,
+ test_name='lint_test_files',
+ test_command=cmd,
+ do_step_if=self.TestStepFilter)
+
def AddWebkitTests(self, gpu, factory_properties=None):
"""Adds a step to the factory to run the WebKit layout tests.

Powered by Google App Engine
This is Rietveld 408576698