Adds a 'webkit_lint' test step to the bots

scripts/master/factory/chromium_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory.
 
 This is based on commands.py and adds chromium-specific commands."""
 
 import logging
 import os
@@ skipping 727 matching lines @@
            '--target', self._target,
            '--build-dir', self._build_dir,
            'inspector'
     ]
 
     self.AddTestStep(c,
                      test_name='DevTools.PerfTest',
                      test_command=cmd,
                      do_step_if=self.TestStepFilter)
 
+  def AddWebkitLint(self, factory_properties=None):
+    """Adds a step to the factory to lint the WebKit test_expectations.txt file."""

[nsylvain, 2012/01/25 20:19:54]

80 chars

[Dirk Pranke, 2012/01/25 22:39:07]

Done.

+    factory_properties = factory_properties or {}

[nsylvain, 2012/01/25 20:19:54]

i dont think you need this line

[Dirk Pranke, 2012/01/25 22:39:07]

Done.

+    cmd = [self._python, self._lint_test_files_tool]
+    self.AddTestStep(shell.ShellCommand,
+                     test_name='lint_test_files',
+                     test_command=cmd,
+                     do_step_if=self.TestStepFilter)
+
   def AddWebkitTests(self, gpu, factory_properties=None):
     """Adds a step to the factory to run the WebKit layout tests.
 
     Args:
       gpu: if True, run the GPU-acclerated variant of the tests.
       with_pageheap: if True, page-heap checking will be enabled for test_shell
       test_timeout: buildbot timeout for the test step
       archive_timeout: buildbot timeout for archiving the test results and
           crashes, if requested
       archive_results: whether to archive the test results
@@ skipping 240 matching lines @@
   # ArchiveCommand.createSummary.
   return '%s/%s/%s' % (config.Master.archive_url, archive_type, builder_name)
 
 def _GetSnapshotUrl(factory_properties=None, builder_name='%(build_name)s'):
   if not factory_properties or 'gs_bucket' not in factory_properties:
     return (_GetArchiveUrl('snapshots', builder_name), None)
   gs_bucket = factory_properties['gs_bucket']
   gs_bucket = re.sub(r'^gs://', 'http://commondatastorage.googleapis.com/',
                      gs_bucket)
   return ('%s/index.html?path=%s' % (gs_bucket, builder_name), '/')