Remove "high"-latency audio code path

Remove "high"-latency audio code path

Chrome only uses the low-latency code path. This CL removes the unused,
alternative "high"-latency code path. player_x11 and player_wtl use the
high-latency code path, so sound is disabled from those players for now.

BUG=NONE
TEST=builds; content_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120436

[vrk (LEFT CHROMIUM), 2012-01-28 00:19:44]

scherkus: Please review! I've kept "LowLatency" in the names of things for now;
I think the rename would be easier to review in a follow-up CL.

others: purely fyi! comment if you wish :)

[scherkus (not reviewing), 2012-01-28 02:12:51]

LGTM w/ nits + q's

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:119:
static_cast<AudioSyncReader*>(entry->reader.get());
do you happen to know why we can't have AudioSyncReader inside the .h for
AudioEntry?

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
File content/renderer/media/audio_message_filter_unittest.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
content/renderer/media/audio_message_filter_unittest.cc:91:
base::SyncSocket::Handle socket_handle;
fix indent

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
File media/audio/audio_output_controller.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.cc:159: number_polling_attempts_left_ =
kPollNumAttempts;
I know you didn't write this but this seems odd

if this has a way of getting fixed we should at least TODO-ify + create a bug

mind tracking this down?

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/tools/player_x...
File media/tools/player_x11/player_x11.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/tools/player_x...
media/tools/player_x11/player_x11.cc:102: bool /* enable_audio */,
can we TODO for adding audio back in w/ bug?

[henrika (OOO until Aug 14), 2012-01-29 20:54:00]

Nice work Victoria. I am glad to see that you clean up in this area.

My main input is that I feel we should remove all references to "low-latency" in
this CL. That goes for IPC messages as well. E.g. remove OnLowLateceyCreated.

I have also added a few comments about parts that you have not written
initially; hope that is OK. As an example, I would like to replace the usage of
audio-controller thread with audio-manager thread to make it more clear which
thread we are referring to.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.cc (left):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:225:
IPC_MESSAGE_HANDLER(AudioHostMsg_GetVolume, OnGetVolume)
Not sure why GetVolume() has been removed and how that is related to this CL.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:135: Send(new
AudioMsg_NotifyLowLatencyStreamCreated(
Proposal: remove "LowLatency"

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:209: // Create the
shared memory and share with the renderer process.
New line above comment.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:230:
entry->controller =
Is it possible to improve indentation here? Feels like line 231 could be moved
up to 230 perhaps.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:240: // If we have
created the controller successfully create a entry and add it
"an entry"

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.h:16: // Here's an
example of a typical IPC dialog for audio:
I assume that these comments must be updated since they are based on the removed
audio path.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.h:153: void
OnSetVolume(int stream_id, double volume);
Why has OnGetVolume() been removed?

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
File content/common/media/audio_messages.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
content/common/media/audio_messages.h:43:
IPC_MESSAGE_CONTROL4(AudioMsg_NotifyLowLatencyStreamCreated,
Why not rename this to _NotifyStreamCreated and remove usage of "low-latency"?

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
File content/renderer/media/audio_device.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
content/renderer/media/audio_device.h:133: virtual void
OnLowLatencyCreated(base::SharedMemoryHandle handle,
Same comment as before. Why do we keep "LowLatency" if we only have one type?

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
File content/renderer/media/audio_message_filter.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
content/renderer/media/audio_message_filter.h:33: virtual void
OnLowLatencyCreated(base::SharedMemoryHandle handle,
Remove LowLatency?

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
File media/audio/audio_output_controller.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:28: // namely the audio controller thread.
Can we please change this comment as well while we are doing work in this area.
I've always found it confusing that we say "audio-controller thread" when it is
fact the audio-manager thread. Talking about an audio-controller thread makes it
sound as is one thread is created per controller and this is not the case.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:50: // AudioSourceCallback interface.
AudioOutputController uses the SyncReader
I think we call the same interface on the render side AudioSink and not Source.
Might be a bit confusing. I feel that Sink is the the correct term since the
interface specifies a data consumption.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:212: // other than the audio controller
thread.
Rename to audio-manager thread?

[scherkus (not reviewing), 2012-01-30 19:02:00]

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:135: Send(new
AudioMsg_NotifyLowLatencyStreamCreated(
On 2012/01/29 20:54:00, henrika wrote:
> Proposal: remove "LowLatency"

Yeah I agree w/ henrika here. I didn't suggest it earlier as I thought we still
needed to distinguish between WASAPI-like low latency output and default output
methods.

We really need to agree on some terminology :P

[vrk (LEFT CHROMIUM), 2012-01-31 23:53:08]

Thanks guys!

Yeah I was always planning on removing the "LowLatency" from the names of
things, but was concerned that doing it in this CL would make things confusing!
(The way that the diffs work out, it sort of looks like I am removing the
low-latency path instead of doing the opposite.)

I addressed all the comments, so PTAL!

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.cc (left):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:225:
IPC_MESSAGE_HANDLER(AudioHostMsg_GetVolume, OnGetVolume)
On 2012/01/29 20:54:00, henrika wrote:
> Not sure why GetVolume() has been removed and how that is related to this CL.

Answered in previous comment!

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:119:
static_cast<AudioSyncReader*>(entry->reader.get());
On 2012/01/28 02:12:52, scherkus wrote:
> do you happen to know why we can't have AudioSyncReader inside the .h for
> AudioEntry?

Doesn't seem like there's a reason not to have it there! Mind if I do the move
in a separate CL?

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:135: Send(new
AudioMsg_NotifyLowLatencyStreamCreated(
On 2012/01/30 19:02:00, scherkus wrote:
> On 2012/01/29 20:54:00, henrika wrote:
> > Proposal: remove "LowLatency"
> 
> Yeah I agree w/ henrika here. I didn't suggest it earlier as I thought we
still
> needed to distinguish between WASAPI-like low latency output and default
output
> methods.
> 
> We really need to agree on some terminology :P

Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:135: Send(new
AudioMsg_NotifyLowLatencyStreamCreated(
On 2012/01/29 20:54:00, henrika wrote:
> Proposal: remove "LowLatency"

Done - Except for the audio input-related LowLatency stuff, as I mentioned in
another comment.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:209: // Create the
shared memory and share with the renderer process.
On 2012/01/29 20:54:00, henrika wrote:
> New line above comment.

Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:230:
entry->controller =
On 2012/01/29 20:54:00, henrika wrote:
> Is it possible to improve indentation here? Feels like line 231 could be moved
> up to 230 perhaps.

Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.cc:240: // If we have
created the controller successfully create a entry and add it
On 2012/01/29 20:54:00, henrika wrote:
> "an entry"

Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
File content/browser/renderer_host/media/audio_renderer_host.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.h:16: // Here's an
example of a typical IPC dialog for audio:
On 2012/01/29 20:54:00, henrika wrote:
> I assume that these comments must be updated since they are based on the
removed
> audio path.

Good catch! Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/browser/rend...
content/browser/renderer_host/media/audio_renderer_host.h:153: void
OnSetVolume(int stream_id, double volume);
On 2012/01/29 20:54:00, henrika wrote:
> Why has OnGetVolume() been removed?

As I was deleting unused code, I noticed that OnGetVolume() is also never used,
so I also deleted that.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
File content/common/media/audio_messages.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
content/common/media/audio_messages.h:43:
IPC_MESSAGE_CONTROL4(AudioMsg_NotifyLowLatencyStreamCreated,
On 2012/01/29 20:54:00, henrika wrote:
> Why not rename this to _NotifyStreamCreated and remove usage of "low-latency"?

Ah, no reason! I was just going to do the rename in follow-up CL to make things
less confusing. But looks like you and scherkus prefer to do the rename in this
CL, so Done!

Also, it looks like the AudioInput messages and classes have "LowLatency" in the
name as well, and it doesn't look like there's an alternative (i.e.
non-low-latency) path there, either. Do you know why LowLatency is kept there,
or should a similar clean-up be done for AudioInput?

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
File content/renderer/media/audio_device.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
content/renderer/media/audio_device.h:133: virtual void
OnLowLatencyCreated(base::SharedMemoryHandle handle,
On 2012/01/29 20:54:00, henrika wrote:
> Same comment as before. Why do we keep "LowLatency" if we only have one type?

See prev comment!
Changed to "OnStreamCreated" to match IPC message.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
File content/renderer/media/audio_message_filter.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
content/renderer/media/audio_message_filter.h:33: virtual void
OnLowLatencyCreated(base::SharedMemoryHandle handle,
On 2012/01/29 20:54:00, henrika wrote:
> Remove LowLatency?

Changed to OnStreamCreated, here and elsewhere.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
File content/renderer/media/audio_message_filter_unittest.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/renderer/med...
content/renderer/media/audio_message_filter_unittest.cc:91:
base::SyncSocket::Handle socket_handle;
On 2012/01/28 02:12:52, scherkus wrote:
> fix indent

Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
File media/audio/audio_output_controller.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.cc:159: number_polling_attempts_left_ =
kPollNumAttempts;
On 2012/01/28 02:12:52, scherkus wrote:
> I know you didn't write this but this seems odd
> 
> if this has a way of getting fixed we should at least TODO-ify + create a bug
> 
> mind tracking this down?

Done. Details in the bug! (crbug.com/112196)

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
File media/audio/audio_output_controller.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:28: // namely the audio controller thread.
On 2012/01/29 20:54:00, henrika wrote:
> Can we please change this comment as well while we are doing work in this
area.
> I've always found it confusing that we say "audio-controller thread" when it
is
> fact the audio-manager thread.

Sure! Done, and combed through the comments in this file to specify audio
manager thread.

> Talking about an audio-controller thread makes it
> sound as is one thread is created per controller and this is not the case.

Yeah, especially since the comment above Create() basically said that, too :)
Fixed the Create() comment as well.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:50: // AudioSourceCallback interface.
AudioOutputController uses the SyncReader
On 2012/01/29 20:54:00, henrika wrote:
> I think we call the same interface on the render side AudioSink and not
Source.
> Might be a bit confusing. I feel that Sink is the the correct term since the
> interface specifies a data consumption. 

Yeah, I am planning to go through and rename some of these interfaces and
methods to make things more uniform. Probably in a follow-up CL?

For now, I'll leave this comment as-is if that's okay.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:212: // other than the audio controller
thread.
On 2012/01/29 20:54:00, henrika wrote:
> Rename to audio-manager thread?

Done.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/tools/player_x...
File media/tools/player_x11/player_x11.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/tools/player_x...
media/tools/player_x11/player_x11.cc:102: bool /* enable_audio */,
On 2012/01/28 02:12:52, scherkus wrote:
> can we TODO for adding audio back in w/ bug?

Done.

[henrika (OOO until Aug 14), 2012-02-01 13:11:29]

LGTM w/ nits.

PS - I am working on refactoring the AudioInputController. Will sync up with
this CL as soon as you have landed.

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
File content/common/media/audio_messages.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
content/common/media/audio_messages.h:43:
IPC_MESSAGE_CONTROL4(AudioMsg_NotifyLowLatencyStreamCreated,
The SpeechInput API are still using the "old" path and e.g. WebRTC & Pepper the
low-latency version. Hence, we need to keep both alternatives.

I am working a refactoring AudioInputController right now and will make more
changes in this area. In short, I can take care of the capture parts. Just let
me know if you see something that needs attention.

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
File media/audio/audio_output_controller.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/media/audio/audio_ou...
media/audio/audio_output_controller.h:50: // AudioSourceCallback interface.
AudioOutputController uses the SyncReader
Sounds fine.

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
File media/audio/audio_output_controller.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
media/audio/audio_output_controller.cc:159: // TODO(vrk): The polling here and
in WaitTillDataReady() is pretty clunky.
Thanks. This part is magic to me as well.

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
File media/audio/audio_output_controller.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
media/audio/audio_output_controller.h:114: // This posts a method on the
|audio_manager|'s thread to create an
Would it be possible to make this comment a bit more clear? Isn't the essential
information that OnCreated() is always called on the audio-manager thread? 

Proposal:

"Factory method for creating an AudioOutputController.
The audio device will be created on the audio thread, and when that is done, the
event handler will receive an OnCreated() call from that same thread."

[scherkus (not reviewing), 2012-02-01 22:56:12]

LGTM w/ q's

http://codereview.chromium.org/9121062/diff/12003/content/common/media/audio_...
File content/common/media/audio_messages.h (right):

http://codereview.chromium.org/9121062/diff/12003/content/common/media/audio_...
content/common/media/audio_messages.h:39: // Tell the renderer process that a
low latency audio stream has been created,
update docs?

http://codereview.chromium.org/9121062/diff/12003/content/renderer/media/audi...
File content/renderer/media/audio_device.cc (right):

http://codereview.chromium.org/9121062/diff/12003/content/renderer/media/audi...
content/renderer/media/audio_device.cc:24:
latency_format_(AudioParameters::AUDIO_PCM_LOW_LATENCY),
does this also need to get updated?

is this always LOW_LATENCY or do people override it in Initialize()?

http://codereview.chromium.org/9121062/diff/12003/content/renderer/media/audi...
File content/renderer/media/audio_device.h (right):

http://codereview.chromium.org/9121062/diff/12003/content/renderer/media/audi...
content/renderer/media/audio_device.h:19: // AudioDevice::RenderCallback at
construction and will be polled by the
update docs?

[vrk (LEFT CHROMIUM), 2012-02-02 21:05:40]

Thanks for the reviews, guys! Addressed comments and will try to land later
today if try bots look clear.

As discussed offline with scherkus: much of the AudioOutputController unit test
was largely written to test the high-latency code path, and the part of the unit
test that intended to test the low-latency code path was no longer valid. I
simply deleted the invalid tests and created a bug to rewrite them
(crbug.com/112500).

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
File content/common/media/audio_messages.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/1019/content/common/media...
content/common/media/audio_messages.h:43:
IPC_MESSAGE_CONTROL4(AudioMsg_NotifyLowLatencyStreamCreated,
On 2012/02/01 13:11:29, henrika wrote:
> The SpeechInput API are still using the "old" path and e.g. WebRTC & Pepper
the
> low-latency version. Hence, we need to keep both alternatives.
> 
> I am working a refactoring AudioInputController right now and will make more
> changes in this area. In short, I can take care of the capture parts. Just let
> me know if you see something that needs attention.

Awesome, sounds great! Will do if I run into anything :)

https://chromiumcodereview.appspot.com/9121062/diff/12003/content/common/medi...
File content/common/media/audio_messages.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/content/common/medi...
content/common/media/audio_messages.h:39: // Tell the renderer process that a
low latency audio stream has been created,
On 2012/02/01 22:56:12, scherkus wrote:
> update docs?

Done.

https://chromiumcodereview.appspot.com/9121062/diff/12003/content/renderer/me...
File content/renderer/media/audio_device.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/content/renderer/me...
content/renderer/media/audio_device.cc:24:
latency_format_(AudioParameters::AUDIO_PCM_LOW_LATENCY),
On 2012/02/01 22:56:12, scherkus wrote:
> does this also need to get updated?
> 
> is this always LOW_LATENCY or do people override it in Initialize()?

Ooh, I didn't even notice this! Looked into this and turns out this is referring
to a different sort of low latency, see crbug.com/103627.

As the bug describes, AudioRendererImpl is using AUDIO_PCM_LINEAR when it's
initialized, so can't get rid of the option yet.

https://chromiumcodereview.appspot.com/9121062/diff/12003/content/renderer/me...
File content/renderer/media/audio_device.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/content/renderer/me...
content/renderer/media/audio_device.h:19: // AudioDevice::RenderCallback at
construction and will be polled by the
On 2012/02/01 22:56:12, scherkus wrote:
> update docs?

Changed a few words, but otherwise these comments seem accurate still. Let me
know if there was something else you were concerned about here!

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
File media/audio/audio_output_controller.cc (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
media/audio/audio_output_controller.cc:159: // TODO(vrk): The polling here and
in WaitTillDataReady() is pretty clunky.
On 2012/02/01 13:11:29, henrika wrote:
> Thanks. This part is magic to me as well.

:)

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
File media/audio/audio_output_controller.h (right):

https://chromiumcodereview.appspot.com/9121062/diff/12003/media/audio/audio_o...
media/audio/audio_output_controller.h:114: // This posts a method on the
|audio_manager|'s thread to create an
On 2012/02/01 13:11:29, henrika wrote:
> Would it be possible to make this comment a bit more clear? Isn't the
essential
> information that OnCreated() is always called on the audio-manager thread? 
> 
> Proposal:
> 
> "Factory method for creating an AudioOutputController.
> The audio device will be created on the audio thread, and when that is done,
the
> event handler will receive an OnCreated() call from that same thread."

Done.

[commit-bot: I haz the power, 2012-02-03 01:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vrk@chromium.org/9121062/15025

[commit-bot: I haz the power, 2012-02-03 01:14:59]

Presubmit check for 9121062-15025 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: content/renderer/pepper_plugin_delegate_impl.cc

Presubmit checks took 2.0s to calculate.

[vrk (LEFT CHROMIUM), 2012-02-03 01:23:24]

piman: Please OWNERS review content/renderer/pepper_plugin_delegate_impl.cc.
Thanks!

[piman, 2012-02-03 18:26:44]

rubber-stamp lgtm

[commit-bot: I haz the power, 2012-02-03 18:48:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vrk@chromium.org/9121062/15025

[commit-bot: I haz the power, 2012-02-03 18:49:01]

Can't apply patch for file media/audio/audio_output_controller_unittest.cc.
While running patch -p1 --forward --force;
patching file media/audio/audio_output_controller_unittest.cc
Hunk #4 succeeded at 80 (offset -4 lines).
Hunk #5 succeeded at 106 (offset -4 lines).
Hunk #6 succeeded at 124 (offset -4 lines).
Hunk #7 succeeded at 140 (offset -4 lines).
Hunk #8 FAILED at 152.
1 out of 8 hunks FAILED -- saving rejects to file
media/audio/audio_output_controller_unittest.cc.rej

[commit-bot: I haz the power, 2012-02-03 21:50:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vrk@chromium.org/9121062/12020

[commit-bot: I haz the power, 2012-02-03 23:18:20]

Change committed as 120436