Issue 9117032: Reduce the space used by the stack for the profiling thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9117032: Reduce the space used by the stack for the profiling thread. (Closed)

Created:
8 years, 11 months ago by Erik Corry

Modified:
8 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Reduce the space used by the stack for the profiling thread. Committed: https://code.google.com/p/v8/source/detail?r=10490

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -73 lines)			Patch
M	src/cpu-profiler.cc	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	src/d8.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/platform.h	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	src/platform-freebsd.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	src/platform-linux.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	src/platform-macos.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	src/platform-openbsd.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	src/platform-solaris.cc	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	src/platform-win32.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 11 months ago (2012-01-24 15:45:42 UTC) #2

LGTM (with a nit).

https://chromiumcodereview.appspot.com/9117032/diff/2003/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://chromiumcodereview.appspot.com/9117032/diff/2003/src/cpu-profiler.cc#...
src/cpu-profiler.cc:43: static const int kTickSamplesBufferChunkSize = 64*KB;
I know this is not part of your change, but could you add spaces before and
after the multiplication operator here?

Expand Messages | Collapse Messages