Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/cpu-profiler.cc

Issue 9117032: Reduce the space used by the stack for the profiling thread. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 22 matching lines...) Expand all
33 #include "hashmap.h" 33 #include "hashmap.h"
34 #include "log-inl.h" 34 #include "log-inl.h"
35 #include "vm-state-inl.h" 35 #include "vm-state-inl.h"
36 36
37 #include "../include/v8-profiler.h" 37 #include "../include/v8-profiler.h"
38 38
39 namespace v8 { 39 namespace v8 {
40 namespace internal { 40 namespace internal {
41 41
42 static const int kEventsBufferSize = 256*KB; 42 static const int kEventsBufferSize = 256*KB;
43 static const int kTickSamplesBufferChunkSize = 64*KB; 43 static const int kTickSamplesBufferChunkSize = 64*KB;
Michael Starzinger 2012/01/24 15:45:42 I know this is not part of your change, but could
44 static const int kTickSamplesBufferChunksCount = 16; 44 static const int kTickSamplesBufferChunksCount = 16;
45 static const int kProfilerStackSize = 32 * KB;
45 46
46 47
47 ProfilerEventsProcessor::ProfilerEventsProcessor(ProfileGenerator* generator) 48 ProfilerEventsProcessor::ProfilerEventsProcessor(ProfileGenerator* generator)
48 : Thread("v8:ProfEvntProc"), 49 : Thread(Thread::Options("v8:ProfEvntProc", kProfilerStackSize)),
49 generator_(generator), 50 generator_(generator),
50 running_(true), 51 running_(true),
51 ticks_buffer_(sizeof(TickSampleEventRecord), 52 ticks_buffer_(sizeof(TickSampleEventRecord),
52 kTickSamplesBufferChunkSize, 53 kTickSamplesBufferChunkSize,
53 kTickSamplesBufferChunksCount), 54 kTickSamplesBufferChunksCount),
54 enqueue_order_(0) { 55 enqueue_order_(0) {
55 } 56 }
56 57
57 58
58 void ProfilerEventsProcessor::CallbackCreateEvent(Logger::LogEventsAndTags tag, 59 void ProfilerEventsProcessor::CallbackCreateEvent(Logger::LogEventsAndTags tag,
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 573
573 void CpuProfiler::TearDown() { 574 void CpuProfiler::TearDown() {
574 Isolate* isolate = Isolate::Current(); 575 Isolate* isolate = Isolate::Current();
575 if (isolate->cpu_profiler() != NULL) { 576 if (isolate->cpu_profiler() != NULL) {
576 delete isolate->cpu_profiler(); 577 delete isolate->cpu_profiler();
577 } 578 }
578 isolate->set_cpu_profiler(NULL); 579 isolate->set_cpu_profiler(NULL);
579 } 580 }
580 581
581 } } // namespace v8::internal 582 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698