Issue 9113095: Revert 119284 - Turn web intents build flag on. Move the command-line flag to default on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9113095: Revert 119284 - Turn web intents build flag on. Move the command-line flag to default on. (Closed)

Created:
8 years, 11 months ago by Greg Billock

Modified:
8 years, 11 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 119284 - Turn web intents build flag on. Move the command-line flag to default on. Make the flag disable rather than enable web intents. Put the options UI behind a new flag controlling functionality if the registration tag is present for web content. IN CASE OF FIRE, PULL THIS HANDLE! If web intents needs to be disabled, revert this change. R=jhawkins@chromium.org BUG=90458 TEST=None Review URL: https://chromiumcodereview.appspot.com/9212036 TBR=gbillock@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119306

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -36 lines)			Patch
M	build/common.gypi	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/options.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options_bundle.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/content_settings.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/options.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options2/options_bundle.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/content_settings_handler.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
MM	chrome/browser/ui/webui/options2/content_settings_handler2.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension_manifests_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/intents/intent_injector.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/01/26 22:56:28, Greg Billock wrote:

lgtm

Expand Messages | Collapse Messages