Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: ppapi/thunk/ppb_transport_thunk.cc

Issue 9113044: Convert to new enter method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove common.h Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/thunk/ppb_transport_thunk.cc
diff --git a/ppapi/thunk/ppb_transport_thunk.cc b/ppapi/thunk/ppb_transport_thunk.cc
index 0e6e7d7962f5d30717b22ed02cbb17e992f30080..c449c87a035a774b95382ae60283d541065a8967 100644
--- a/ppapi/thunk/ppb_transport_thunk.cc
+++ b/ppapi/thunk/ppb_transport_thunk.cc
@@ -4,7 +4,6 @@
#include "ppapi/c/pp_completion_callback.h"
#include "ppapi/c/pp_errors.h"
-#include "ppapi/thunk/common.h"
#include "ppapi/thunk/enter.h"
#include "ppapi/thunk/thunk.h"
#include "ppapi/thunk/ppb_transport_api.h"
@@ -41,56 +40,52 @@ int32_t SetProperty(PP_Resource transport, PP_TransportProperty property,
PP_Var value) {
EnterTransport enter(transport, true);
if (enter.failed())
- return PP_ERROR_BADRESOURCE;
+ return enter.retval();
return enter.object()->SetProperty(property, value);
}
int32_t Connect(PP_Resource transport, PP_CompletionCallback callback) {
- EnterTransport enter(transport, true);
+ EnterTransport enter(transport, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Connect(callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->Connect(callback));
}
int32_t GetNextAddress(PP_Resource transport, PP_Var* address,
PP_CompletionCallback callback) {
- EnterTransport enter(transport, true);
+ EnterTransport enter(transport, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->GetNextAddress(address, callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->GetNextAddress(address, callback));
}
int32_t ReceiveRemoteAddress(PP_Resource transport, PP_Var address) {
EnterTransport enter(transport, true);
if (enter.failed())
- return PP_ERROR_BADRESOURCE;
+ return enter.retval();
return enter.object()->ReceiveRemoteAddress(address);
}
int32_t Recv(PP_Resource transport, void* data, uint32_t len,
PP_CompletionCallback callback) {
- EnterTransport enter(transport, true);
+ EnterTransport enter(transport, callback, true);
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Recv(data, len, callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->Recv(data, len, callback));
}
int32_t Send(PP_Resource transport, const void* data, uint32_t len,
PP_CompletionCallback callback) {
EnterTransport enter(transport, true);
yzshen1 2012/01/25 19:11:01 callback, please.
if (enter.failed())
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Send(data, len, callback);
- return MayForceCallback(callback, result);
+ return enter.retval();
+ return enter.SetResult(enter.object()->Send(data, len, callback));
}
int32_t Close(PP_Resource transport) {
EnterTransport enter(transport, true);
if (enter.failed())
- return PP_ERROR_BADRESOURCE;
+ return enter.retval();
return enter.object()->Close();
}

Powered by Google App Engine
This is Rietveld 408576698