Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: ppapi/thunk/ppb_layer_compositor_thunk.cc

Issue 9113044: Convert to new enter method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove common.h Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/thunk/ppb_layer_compositor_thunk.cc
diff --git a/ppapi/thunk/ppb_layer_compositor_thunk.cc b/ppapi/thunk/ppb_layer_compositor_thunk.cc
index df03a43eb9d0a4820911f008851a234d3112d593..98007d3553321d0f58c8be1fd9a63d910e66d296 100644
--- a/ppapi/thunk/ppb_layer_compositor_thunk.cc
+++ b/ppapi/thunk/ppb_layer_compositor_thunk.cc
@@ -4,7 +4,6 @@
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/dev/ppb_layer_compositor_dev.h"
-#include "ppapi/thunk/common.h"
#include "ppapi/thunk/enter.h"
#include "ppapi/thunk/thunk.h"
#include "ppapi/thunk/ppb_layer_compositor_api.h"
@@ -46,7 +45,7 @@ void MarkAsDirty(PP_Resource compositor, PP_Resource layer) {
int32_t SwapBuffers(PP_Resource compositor,
struct PP_CompletionCallback callback) {
- return MayForceCallback(callback, PP_ERROR_FAILED);
+ return PP_ERROR_NOINTERFACE;
yzshen1 2012/01/25 19:11:01 This breaks the convention of how |callback| is us
brettw 2012/01/25 19:54:12 The problem is that since there's no implementatio
yzshen1 2012/01/25 20:06:26 Okay. I am okay to leave it unchanged. I just tho
brettw 2012/01/26 05:17:40 Yeah, but EnterResource is a template, so I have t
yzshen1 2012/01/27 18:25:47 [Again, I am fine with the current approach.] I th
}
const PPB_LayerCompositor_Dev g_ppb_layer_compositor_thunk = {

Powered by Google App Engine
This is Rietveld 408576698