Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 908093003: Revert of Add support for ContentViewCore helpers on Tab (Closed)

Created:
5 years, 10 months ago by David Trainor- moved to gerrit
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jam, avayvod+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for ContentViewCore helpers on Tab (patchset #7 id:120001 of https://chromiumcodereview.appspot.com/900443003/) Reason for revert: Downstream CL didn't land cleanly. Need to revert. Original issue's description: > Add suppor for ContentViewCore helpers on Tab > > - Add a concept of a helper ContentViewCore to Tab. > - Properly attach these ContentViewCores to the Tabs rendering layer. > - Note that these aren't rendered by ContentViewRenderView yet. We need a Chrome-level > rendering object for that. > > BUG= > > Committed: https://crrev.com/307787f6e1fd7f3affa872faf6e2efefcc51eb73 > Cr-Commit-Position: refs/heads/master@{#315405} TBR=dfalcantara@chromium.org,changwan@chromium.org,jaekyun@chromium.org,tedchoc@chromium.org,enne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7ad18bfea595fac493788fcb2427c68852b7437d Cr-Commit-Position: refs/heads/master@{#315467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -225 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 5 chunks +6 lines, -88 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 3 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/tab_android.h View 5 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 5 chunks +0 lines, -54 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
David Trainor- moved to gerrit
Created Revert of Add support for ContentViewCore helpers on Tab
5 years, 10 months ago (2015-02-10 01:37:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908093003/1
5 years, 10 months ago (2015-02-10 01:37:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 01:38:32 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 01:40:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ad18bfea595fac493788fcb2427c68852b7437d
Cr-Commit-Position: refs/heads/master@{#315467}

Powered by Google App Engine
This is Rietveld 408576698