content/browser/android/content_view_core_impl.cc - Issue 908093003: Revert of Add support for ContentViewCore helpers on Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 908093003: Revert of Add support for ContentViewCore helpers on Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 71225b7cd0b10846186ccf2398f896907d25634f..4cbc111c061ef455bca4c69ed80b63af6bcfb8b6 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -256,8 +256,6 @@

}

ContentViewCoreImpl::~ContentViewCoreImpl() {

- root_layer_->RemoveFromParent();

JNIEnv* env = base::android::AttachCurrentThread();

ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);

java_ref_.reset();

@@ -1305,12 +1303,6 @@

}

-void ContentViewCoreImpl::SetDrawsContent(JNIEnv* env,

- jobject jobj,

- jboolean draws) {

- GetLayer()->SetHideLayerAndSubtree(!draws);

void ContentViewCoreImpl::RequestTextSurroundingSelection(

int max_length,

const base::Callback<