Issue 898743002: When an extension is unloaded, unregister all event listeners, not just the lazy ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898743002: When an extension is unloaded, unregister all event listeners, not just the lazy ones. (Closed)

Created:
5 years, 10 months ago by Marijn Kruisselbrink

Modified:
5 years, 10 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

Merge to M41: When an extension is unloaded, unregister all event listeners, not just the lazy ones. This fixes a problem where event listeners could stick around for a short time period after an extension is unloaded, causing problems with the onInstalled event for a new version of an extension. BUG=449654 Review URL: https://codereview.chromium.org/877233002 Cr-Commit-Position: refs/heads/master@{#313556} (cherry picked from commit 1a3586c0467a2e2f3777c060616e787bc9535c19) TBR=kalman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/390a35bd3dc185cd091df0a40ae05fcf6b35642e

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -10 lines)			Patch
M	extensions/browser/event_listener_map.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	extensions/browser/event_listener_map.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	extensions/browser/event_listener_map_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/browser/event_router.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Marijn Kruisselbrink

5 years, 10 months ago (2015-02-03 15:02:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
390a35bd3dc185cd091df0a40ae05fcf6b35642e (presubmit successful).