Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 890583003: dart2js: move recording of interceptorInvocationNames from addParameterStub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
index b221f8889a045c6766dbdb998b9e8aeed9c0c450..59645fee4a0c6a2f4b276817d244a5b1d1f531bd 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
@@ -62,7 +62,6 @@ class ContainerBuilder extends CodeEmitterHelper {
count++;
parametersBuffer[0] = new jsAst.Parameter(receiverArgumentName);
argumentsBuffer[0] = js('#', receiverArgumentName);
- emitter.interceptorEmitter.interceptorInvocationNames.add(invocationName);
}
int optionalParameterStart = positionalArgumentCount + extraArgumentCount;
@@ -259,9 +258,11 @@ class ContainerBuilder extends CodeEmitterHelper {
addParameterStubs(
member,
(Selector selector, jsAst.Fun function) {
+ String invocationName = namer.invocationName(selector);
+ emitter.interceptorEmitter.
floitsch 2015/01/29 20:52:48 nit: put the "." into the next line.
zarah 2015/01/30 07:53:31 Done.
+ recordMangledNameOfMemberMethod(member, invocationName);
compiler.dumpInfoTask.registerElementAst(member,
- builder.addProperty(namer.invocationName(selector),
- function));
+ builder.addProperty(invocationName, function));
});
}
return;
@@ -336,11 +337,15 @@ class ContainerBuilder extends CodeEmitterHelper {
if (needsStubs || canTearOff) {
addParameterStubs(member, (Selector selector, jsAst.Fun function) {
+
+ String invocationName = namer.invocationName(selector);
+ emitter.interceptorEmitter.
+ recordMangledNameOfMemberMethod(member, invocationName);
expressions.add(function);
if (member.isInstanceMember) {
Set invokedSelectors =
compiler.codegenWorld.invokedNames[member.name];
- expressions.add(js.string(namer.invocationName(selector)));
+ expressions.add(js.string(invocationName));
} else {
expressions.add(js('null'));
// TOOD(ahe): Since we know when reading static data versus instance
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698